Bug 51731 – [Chromium] storage/indexeddb/objectstore-basics.html is flaky after r74266

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Mihai Parparita]

storage/indexeddb/objectstore-basics.html became flaky on 12/17, with the first failure being at r74269. Timing-wise this coincides well with the changes made by r74266, so I'm suspecting that as the culprit.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&master=ChromiumWebkit&tests=storage%2Findexeddb%2Fobjectstore-basics.html

[Hans Wennborg]

Looking. This reproduces locally on my machine. Running 20 or so times, I sometimes get this text diff:

--- /work/chrome/src/webkit/Debug/layout-test-results/storage/indexeddb/objectstore-basics-expected.txt 
+++ /work/chrome/src/webkit/Debug/layout-test-results/storage/indexeddb/objectstore-basics-actual.txt 
@@ -199,7 +199,7 @@
 PASS 'readyState' in event.target is true
 PASS event.target.readyState is event.target.DONE
 
-PASS event.result.y is "value"
+FAIL event.result.y should be value. Threw exception TypeError: Cannot read property 'y' of null
 store = event.source
 store.get(testDate)
 getSuccessDateKey():

[Hans Wennborg]

This is caused by Chromium bug http://crbug.com/67918, where we fail to store some values in the database.

Since the test stores an object containing "new Date()", that object is sometimes not stored successfully, and the test breaks.

While we fix the underlying problem, we can re-enable the test by using a known-good Date.

[Hans Wennborg]

Created attachment 78007 [details]
Patch

[Mihai Parparita]

(In reply to comment #3)
> Created an attachment (id=78007) [details]
> Patch

That seems fine to me, but unfortunately I'm not a reviewer yet.

[Jeremy Orlow]

Comment on attachment 78007 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 78007 [details]
Patch

Clearing flags on attachment: 78007

Committed r75109: <http://trac.webkit.org/changeset/75109>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.