Bug 51665

Summary: Make fast/canvas/canvas-save-restore-with-path.js more robust
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: Tools / TestsAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, eric, mrobinson, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch eric: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-12-27 20:16:35 PST
Some recent changes to this test indicated that it isn't as robust as desired because it samples pixels right on the boundary between two regions being filled, rather than in the middle of the filled region (presumably as desired). By moving the sample points around we can make it more robust to future changes.
Attachments
Patch (2.09 KB, patch)
2010-12-27 20:20 PST, Kenneth Russell 		eric: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-12-27 20:20:58 PST
Created attachment 77535 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-28 13:55:36 PST
Comment on attachment 77535 [details] Patch OK.
Kenneth Russell
Comment 3 2010-12-28 15:16:42 PST
Committed r74729: <http://trac.webkit.org/changeset/74729>
Martin Robinson
Comment 4 2010-12-28 15:30:39 PST
Thanks for fixing this in a better way!
WebKit Review Bot
Comment 5 2010-12-28 16:18:27 PST
http://trac.webkit.org/changeset/74729 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.