Bug 51657

Summary: Substitute // MARK: for compiler-specific #pragma mark
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2010-12-27 16:03:35 PST
I noticed today (12/27) that the GTK bot complained about the compiler-specific #pragma mark code-bookmarking functionality: ../../Tools/DumpRenderTree/AccessibilityTextMarker.cpp:32: warning: ignoring #pragma mark AccessibilityTextMarker ../../Tools/DumpRenderTree/AccessibilityTextMarker.cpp:84: warning: ignoring #pragma mark AccessibilityTextMarkerRange (from <http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/17525/steps/compile-webkit/logs/stdio>) Xcode provides analogous code-bookmarking functionality using the "MARK:" prefix in comments. We should substitute "// MARK:" for "#pragma mark" so as to resolve such compiler warnings.
Attachments
Patch (21.89 KB, patch)
2010-12-27 16:09 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (21.88 KB, patch)
2010-12-27 16:15 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2010-12-27 16:09:46 PST
Created attachment 77523 [details] Patch
Daniel Bates
Comment 2 2010-12-27 16:15:47 PST
Created attachment 77525 [details] Patch Fixed a few instances where I had "#// MARK:" instead of "// MARK:"
Daniel Bates
Comment 3 2010-12-28 16:59:32 PST
Comment on attachment 77525 [details] Patch Clearing flags on attachment: 77525 Committed r74733: <http://trac.webkit.org/changeset/74733>
Daniel Bates
Comment 4 2010-12-28 16:59:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.