Bug 51626

Summary: [EFL] Change the tiled backing store to use constant tile size.
Product: WebKit Reporter: Rafael Antognolli <antognolli+webkit>
Component: WebKit EFLAssignee: Rafael Antognolli <antognolli+webkit>
Status: RESOLVED INVALID    
Severity: Normal CC: barbieri, gyuyoung.kim, kenneth, leandro, sangseok.lim, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch krit: review-, krit: commit-queue-

Rafael Antognolli
Reported 2010-12-26 18:19:50 PST
[EFL] Change the tiled backing store to use constant tile size.
Attachments
Patch (33.88 KB, patch)
2010-12-26 18:25 PST, Rafael Antognolli 		krit: review-
krit: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rafael Antognolli
Comment 1 2010-12-26 18:25:10 PST
Created attachment 77470 [details] Patch
Dirk Schulze
Comment 2 2011-04-26 15:41:03 PDT
Comment on attachment 77470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77470&action=review The patch seems to look good. Anyway it seems not to apply to svn. So you have to update the patch anyway. Just some general comments. While t is even better, it would be much easier to understand the code if you take self explaining names: t -> tile tw tile_width and so on. Because all these names were used in other contexts in the past on other parts of WebCore. (t for transform and so on) > WebKit/efl/ewk/ewk_tiled_backing_store.c:1443 > + if (!priv->render.suspend > + && (priv->changed.model > + || priv->changed.layout)) { This can be moved into one line, or at least in two lines for readability
Leandro Pereira
Comment 3 2011-07-14 14:11:54 PDT
Closing bug as invalid. These changes are being reworked and will be posted again in another bug report.
Note You need to log in before you can comment on or make changes to this bug.