Bug 51614

Summary: GraphicsContext: Avoid no-op calls to setPlatformXXX()
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch kenneth: review+, commit-queue: commit-queue-

Andreas Kling
Reported 2010-12-25 19:49:46 PST
We should check if we're setting the value that's already set and return without calling the setPlatformWhatever() function. (This is for set{StrokeThickness,StrokeStyle,ShouldAntialias,ShouldSmoothFonts,TextDrawingMode,CompositeOperation}.)
Attachments
Proposed patch (2.88 KB, patch)
2010-12-25 19:50 PST, Andreas Kling 		kenneth: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-12-25 19:50:33 PST
Created attachment 77446 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-12-26 02:09:39 PST
Comment on attachment 77446 [details] Proposed patch LGTM
WebKit Commit Bot
Comment 3 2010-12-26 04:05:28 PST
Comment on attachment 77446 [details] Proposed patch Rejecting attachment 77446 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ss ......................... svg/custom ................................................................................................................................................................................................................................ svg/custom/path-zero-strokewidth.svg -> failed Exiting early after 1 failures. 19252 tests run. 431.84s total testing time 19251 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 10 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7333142
WebKit Commit Bot
Comment 4 2010-12-26 05:15:47 PST
Comment on attachment 77446 [details] Proposed patch Rejecting attachment 77446 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ss ......................... svg/custom ................................................................................................................................................................................................................................ svg/custom/path-zero-strokewidth.svg -> failed Exiting early after 1 failures. 19252 tests run. 444.28s total testing time 19251 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 11 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7333146
Eric Seidel (no email)
Comment 5 2011-01-11 03:12:26 PST
Looks like this needs an updated patch.
Andreas Kling
Comment 6 2011-01-11 03:56:23 PST
Sigh. Doing this properly will over-complicate things more than I care for. Closing.
Note You need to log in before you can comment on or make changes to this bug.