Bug 5161

Summary:

move HashMap/HashSet code down to JavaScriptCore

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

WebKit Misc.

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
do it (also renamed HashMap::insert to HashMap::set for clarity)	mjs: review+

Maciej Stachowiak

Reported 2005-09-27 23:47:06 PDT

HashSet and HashMap should be moved down to JavaScriptCore so we can have a single hashtable implementation to meet all our hashing needs.

Attachments
do it (also renamed HashMap::insert to HashMap::set for clarity) (133.57 KB, patch) 2005-09-28 01:44 PDT, Maciej Stachowiak	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Maciej Stachowiak

Comment 1 2005-09-28 01:44:39 PDT

Created attachment 4076 [details] do it (also renamed HashMap::insert to HashMap::set for clarity) I measured and found no JS iBench or cvs-base performance regressions with this patch.

Maciej Stachowiak

Comment 2 2005-09-28 15:17:51 PDT

Comment on attachment 4076 [details] do it (also renamed HashMap::insert to HashMap::set for clarity) Eric said ok to this.

Note You need to log in before you can comment on or make changes to this bug.