Bug 51605

Summary: Move ANGLE to Sources/ThirdParty
Product: WebKit Reporter: Adam Barth <abarth>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, kbr, mjs, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 51606    
Attachments:
Description Flags
mr. patch eric: review+, abarth: commit-queue-

Description Adam Barth 2010-12-25 00:11:46 PST
This move looks pretty easy.  I don't think it should affect the Chromium build as Chromium pulls in ANGLE directly via the Google Code project.
Comment 1 Adam Barth 2010-12-25 00:15:11 PST
Created attachment 77435 [details]
mr. patch

This looks easy.  Maybe deceptively easy?
Comment 2 Mark Rowe (bdash) 2010-12-25 00:54:49 PST
Please coordinate landing this with someone from Apple. It’ll require that we update some of our internal build scripts.
Comment 3 Adam Barth 2010-12-25 00:59:14 PST
Who should I coordinate with?  I'm just finishing some some local testing, but I think this patch is ready to go whenever its convenient on the Apple side.
Comment 4 Mark Rowe (bdash) 2010-12-25 01:02:45 PST
(In reply to comment #3)
> Who should I coordinate with?  I'm just finishing some some local testing, but I think this patch is ready to go whenever its convenient on the Apple side.

Anyone that’s around at the time that you go to land it.
Comment 5 Adam Barth 2010-12-25 01:04:28 PST
> Anyone that’s around at the time that you go to land it.

If I landed it in the next 30 minutes, would you be around?  I'm also happy to wait until normal business hours.
Comment 6 Mark Rowe (bdash) 2010-12-25 01:06:26 PST
(In reply to comment #5)
> > Anyone that’s around at the time that you go to land it.
> 
> If I landed it in the next 30 minutes, would you be around?  I'm also happy to wait until normal business hours.

I’m not near a computer so I couldn’t make the necessary changes.
Comment 7 Adam Barth 2010-12-25 01:07:57 PST
> I’m not near a computer so I couldn’t make the necessary changes.

Ok.  No problem.  I hope the holidays are finding you well.  :)
Comment 8 Adam Barth 2010-12-25 01:17:55 PST
** BUILD SUCCEEDED **

This patch build cleanly on Apple Mac.
Comment 9 Eric Seidel (no email) 2010-12-26 13:28:26 PST
Comment on attachment 77435 [details]
mr. patch

rs=me.
Comment 10 Adam Barth 2010-12-26 21:51:58 PST
Landed in 74674.  Maciej has kindly offered to make the internal change.  Thanks everyone.