Bug 51605

Summary:

Move ANGLE to Sources/ThirdParty

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Images

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, kbr, mjs, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

51606

Attachments:

Description	Flags
mr. patch	eric: review+, abarth: commit-queue-

Adam Barth

Reported 2010-12-25 00:11:46 PST

This move looks pretty easy. I don't think it should affect the Chromium build as Chromium pulls in ANGLE directly via the Google Code project.

Attachments
mr. patch (1.53 MB, patch) 2010-12-25 00:15 PST, Adam Barth	eric: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-12-25 00:15:11 PST

Created attachment 77435 [details] mr. patch This looks easy. Maybe deceptively easy?

Mark Rowe (bdash)

Comment 2 2010-12-25 00:54:49 PST

Please coordinate landing this with someone from Apple. It’ll require that we update some of our internal build scripts.

Adam Barth

Comment 3 2010-12-25 00:59:14 PST

Who should I coordinate with? I'm just finishing some some local testing, but I think this patch is ready to go whenever its convenient on the Apple side.

Mark Rowe (bdash)

Comment 4 2010-12-25 01:02:45 PST

(In reply to comment #3) > Who should I coordinate with? I'm just finishing some some local testing, but I think this patch is ready to go whenever its convenient on the Apple side. Anyone that’s around at the time that you go to land it.

Adam Barth

Comment 5 2010-12-25 01:04:28 PST

> Anyone that’s around at the time that you go to land it. If I landed it in the next 30 minutes, would you be around? I'm also happy to wait until normal business hours.

Mark Rowe (bdash)

Comment 6 2010-12-25 01:06:26 PST

(In reply to comment #5) > > Anyone that’s around at the time that you go to land it. > > If I landed it in the next 30 minutes, would you be around? I'm also happy to wait until normal business hours. I’m not near a computer so I couldn’t make the necessary changes.

Adam Barth

Comment 7 2010-12-25 01:07:57 PST

> I’m not near a computer so I couldn’t make the necessary changes. Ok. No problem. I hope the holidays are finding you well. :)

Adam Barth

Comment 8 2010-12-25 01:17:55 PST

** BUILD SUCCEEDED ** This patch build cleanly on Apple Mac.

Eric Seidel (no email)

Comment 9 2010-12-26 13:28:26 PST

Comment on attachment 77435 [details] mr. patch rs=me.

Adam Barth

Comment 10 2010-12-26 21:51:58 PST

Landed in 74674. Maciej has kindly offered to make the internal change. Thanks everyone.

Note You need to log in before you can comment on or make changes to this bug.