Bug 51603

Summary: REGRESSION (r74648): XHR layout test failures
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson
Priority: P1 Keywords: LayoutTestFailure, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Revert the shouldUseCredentialStorage() change from r74648
none
Revert r74648 ap: review+

mitz
Reported 2010-12-24 17:04:48 PST
After r74648, xmlhttprequest/logout.html is failing and xmlhttprequest/basic-auth-default.html is failing whe run interactively.
Attachments
Revert the shouldUseCredentialStorage() change from r74648 (1.60 KB, patch)
2010-12-24 17:21 PST, mitz 		no flags
DetailsFormatted DiffDiff
Revert r74648 (5.30 KB, patch)
2010-12-24 17:37 PST, mitz 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2010-12-24 17:21:35 PST
Created attachment 77430 [details] Revert the shouldUseCredentialStorage() change from r74648
mitz
Comment 2 2010-12-24 17:30:05 PST
I am going to resolve this by reverting r74648.
Alexey Proskuryakov
Comment 3 2010-12-24 17:31:39 PST
Comment on attachment 77430 [details] Revert the shouldUseCredentialStorage() change from r74648 Hmm, does this also make connectionShouldUseCredentialStorage: return YES? If so, then the consequences are more profound than described in the ChangeLog.
mitz
Comment 4 2010-12-24 17:37:44 PST
Created attachment 77431 [details] Revert r74648
mitz
Comment 5 2010-12-24 17:52:46 PST
Fixed in <http://trac.webkit.org/changeset/74657>.
Note You need to log in before you can comment on or make changes to this bug.