Bug 51579

Summary: webkitpy.layout_tests.layout_package.message_broker_unittest.MultiThreadedBrokerTest failed on commit-queue
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, mihaip, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
update w/ fix in r76073, try again none

Eric Seidel (no email)
Reported 2010-12-23 20:02:47 PST
webkitpy.layout_tests.layout_package.message_broker_unittest.MultiThreadedBrokerTest failed on commit-queue http://queues.webkit.org/results/7283157 FAIL: test_exception (webkitpy.layout_tests.layout_package.message_broker_unittest.MultiThreadedBrokerTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py", line 145, in test_exception self.assertRaises(ValueError, self.run_one_thread, 'Exception') AssertionError: ValueError not raised
Attachments
Patch (2.83 KB, patch)
2011-01-18 14:54 PST, Dirk Pranke
no flags
update w/ fix in r76073, try again (5.02 KB, patch)
2011-02-02 18:17 PST, Dirk Pranke
no flags
Eric Seidel (no email)
Comment 1 2010-12-23 20:03:17 PST
I'm not sure if this is flaky or what.
Dirk Pranke
Comment 2 2010-12-23 20:43:50 PST
odd. could be flaky. is there a way to tell which patch was being applied? Was it the change I just filed (bug 51572), or some other random change?
Eric Seidel (no email)
Comment 3 2010-12-24 00:44:33 PST
There is no easy way to go back from the result id on the bot to the patch/bug combo, sadly.
Eric Seidel (no email)
Comment 4 2011-01-06 13:06:15 PST
Just saw another failure from this test suite on the commit-queue: FAIL: test_timeout (webkitpy.layout_tests.layout_package.message_broker_unittest.MultiThreadedBrokerTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py", line 140, in test_timeout interrupted = self.run_one_thread('Timeout') File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py", line 128, in run_one_thread return broker.run_message_loop() File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py", line 159, in run_message_loop log_wedged_worker(thread.getName(), thread.id()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py", line 176, in log_wedged_worker assert(stack is not None) AssertionError
Eric Seidel (no email)
Comment 5 2011-01-14 12:02:47 PST
We saw this flake again on the commit queue: https://webkit-commit-queue.appspot.com/results/7492048
Mihai Parparita
Comment 6 2011-01-14 16:51:39 PST
Isn't this test (and the code it tests) going away once we switch NRWT to using multiple processes instead of threads?
Dirk Pranke
Comment 7 2011-01-14 17:45:24 PST
(In reply to comment #6) > Isn't this test (and the code it tests) going away once we switch NRWT to using multiple processes instead of threads? Can't say for sure. My current plan is to leave in an option for threads, at least until we're sure multiple processes is stable.
Dirk Pranke
Comment 8 2011-01-18 14:54:29 PST
Dirk Pranke
Comment 9 2011-01-18 15:21:12 PST
Comment on attachment 79335 [details] Patch Clearing flags on attachment: 79335 Committed r76073: <http://trac.webkit.org/changeset/76073>
Dirk Pranke
Comment 10 2011-01-18 15:21:20 PST
All reviewed patches have been landed. Closing bug.
Dirk Pranke
Comment 11 2011-02-02 18:17:22 PST
Created attachment 81019 [details] update w/ fix in r76073, try again
Dirk Pranke
Comment 12 2011-02-02 18:18:04 PST
Comment on attachment 81019 [details] update w/ fix in r76073, try again Whoops. Wrong bug - should've been bug 51572.
Note You need to log in before you can comment on or make changes to this bug.