Bug 51522

Summary:

Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch with headers fix	none

Pratik Solanki

Reported 2010-12-22 23:29:26 PST

We now have a function that returns the device color space - deviceRGBColorSpaceRef(). It is defined in GraphicsContextCG.cpp. We should use that in other CG source code files instead of calling CGColorSpaceCreateDeviceRGB().

Attachments
Patch (27.38 KB, patch) 2010-12-22 23:53 PST, Pratik Solanki	no flags	Details Formatted Diff Diff
Patch with headers fix (27.45 KB, patch) 2010-12-23 10:49 PST, Pratik Solanki	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pratik Solanki

Comment 1 2010-12-22 23:53:45 PST

Created attachment 77311 [details] Patch

Eric Seidel (no email)

Comment 2 2010-12-23 00:59:55 PST

Comment on attachment 77311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77311&action=review Looks OK. > WebCore/platform/graphics/cg/GradientCG.cpp:32 > #include "GraphicsContext.h" > +#include "GraphicsContextCG.h" Do we need bot of these includes?

Pratik Solanki

Comment 3 2010-12-23 08:20:23 PST

(In reply to comment #2) > (From update of attachment 77311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=77311&action=review > > Looks OK. > > > WebCore/platform/graphics/cg/GradientCG.cpp:32 > > #include "GraphicsContext.h" > > +#include "GraphicsContextCG.h" > > Do we need bot of these includes? Yes. Otherwise I get a compile error.

Pratik Solanki

Comment 4 2010-12-23 09:26:10 PST

(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 77311 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=77311&action=review > > > > Looks OK. > > > > > WebCore/platform/graphics/cg/GradientCG.cpp:32 > > > #include "GraphicsContext.h" > > > +#include "GraphicsContextCG.h" > > > > Do we need bot of these includes? > > Yes. Otherwise I get a compile error. Oh, I was wrong. I can just include GraphicsContextCG.h and leave out the include for GraphicsContext.h. Updated patch coming up.

Pratik Solanki

Comment 5 2010-12-23 10:49:45 PST

Created attachment 77349 [details] Patch with headers fix

Eric Seidel (no email)

Comment 6 2010-12-28 22:39:07 PST

Comment on attachment 77349 [details] Patch with headers fix LGTM.

WebKit Commit Bot

Comment 7 2010-12-28 23:45:42 PST

Comment on attachment 77349 [details] Patch with headers fix Clearing flags on attachment: 77349 Committed r74734: <http://trac.webkit.org/changeset/74734>

WebKit Commit Bot

Comment 8 2010-12-28 23:45:49 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.