Summary: | [Qt] [Symbian] Fix build-webkit script for Symbian | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dbates, gyuyoung.kim, mrobinson | ||||||
Priority: | P3 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | S60 3rd edition | ||||||||
Attachments: |
|
Description
Laszlo Gombos
2010-12-22 17:02:47 PST
Created attachment 77281 [details]
proposed patch
Comment on attachment 77281 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=77281&action=review Review tool can't seem to apply the patch, so I doubt this will land w/o an update. > Tools/Scripts/webkitdirs.pm:303 > + # Symbian builds do not have Release/Debug configurations either. > + if (($ENV{"WEBKITOUTPUTDIR"} && (isGtk() || isEfl())) || isSymbian()) { We need to make this into a function. usesPerConfigurationBuildDirectory() or similar. > Tools/Scripts/webkitdirs.pm:1526 > - my $dir = File::Spec->canonpath(baseProductDir()); > - $dir = File::Spec->catfile($dir, $config) unless isSymbian(); > + my $dir = File::Spec->canonpath(productDir()); Is this a symbian specific code path? Otherwise why is this OK for other ports? > Tools/Scripts/webkitdirs.pm:1532 > - push @buildArgs, "OUTPUT_DIR=" . baseProductDir() . "/$config"; > + push @buildArgs, "OUTPUT_DIR=" . $dir; Why is this OK for other ports? Or is this just reverting previously added symbian-specific code? Thanks for the review Eric! . (In reply to comment #2) > (From update of attachment 77281 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=77281&action=review > > Review tool can't seem to apply the patch, so I doubt this will land w/o an update. EWS seems to be green. > > > Tools/Scripts/webkitdirs.pm:303 > > + # Symbian builds do not have Release/Debug configurations either. > > + if (($ENV{"WEBKITOUTPUTDIR"} && (isGtk() || isEfl())) || isSymbian()) { > > We need to make this into a function. usesPerConfigurationBuildDirectory() or similar. Will do. > > > Tools/Scripts/webkitdirs.pm:1526 > > - my $dir = File::Spec->canonpath(baseProductDir()); > > - $dir = File::Spec->catfile($dir, $config) unless isSymbian(); > > + my $dir = File::Spec->canonpath(productDir()); > > Is this a symbian specific code path? Otherwise why is this OK for other ports? This is a Qt specific code path (Symbian being one of the QtWebKit ports). For QtWebKit productDir() returns $baseProductDir/$configuration for all Qt ports except for Symbian (see earlier part of the patch). > > > Tools/Scripts/webkitdirs.pm:1532 > > - push @buildArgs, "OUTPUT_DIR=" . baseProductDir() . "/$config"; > > + push @buildArgs, "OUTPUT_DIR=" . $dir; > > Why is this OK for other ports? Or is this just reverting previously added symbian-specific code? Same as above. Created attachment 77336 [details]
created a separate function
Comment on attachment 77336 [details]
created a separate function
r=me
Comment on attachment 77336 [details] created a separate function Clearing flags on attachment: 77336 Committed r74811: <http://trac.webkit.org/changeset/74811> All reviewed patches have been landed. Closing bug. |