Bug 51457 – [EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Gyuyoung Kim]

WebKit EFL can't play html5 audio now. I look into WebCore in order to find the reason. When MediaPlayer loads content via url, it checks mediaType with file extension. But, if getMIMETypeForExtension() of MIMETypeRegistryEfl.cpp cannot find same mime type with the extension, it returns "application/octet-stream".

String MIMETypeRegistry::getMIMETypeForExtension(const String &ext)
{
    String s = ext.lower();
    const ExtensionMap *e = extensionMap;
    while (e->extension) {
        if (s == e->extension)
            return e->mimeType;
        ++e;
    }

    return "application/octet-stream";
}

But, if the getMIMETypeForExtension() of MIMETypeRegistryEfl.cpp cannot find appropriate mime type, getMIMETypeForExtension() of MIMETypeRegistry.cpp tries to find mime type in mediaMIMETypeMap() of MIMETypeRegistry.cpp.

Unfortunately, HTML5 Audio doesn't be played in WebKit EFL because getMIMETypeForExtension() of MIMETypeRegistryEfl.cpp returns "application/octet-stream".

String MIMETypeRegistry::getMediaMIMETypeForExtension(const String& ext)
{
    // Look in the system-specific registry first.
    String type = getMIMETypeForExtension(ext);
    if (!type.isEmpty())
        return type;

    Vector<String>* typeList = mediaMIMETypeMap().get(ext);
    if (typeList)
        return (*typeList)[0];
    
    return String();
}

So, I change the "application/octet-stream" with "String()". Below demo sites can be worked based on this patch.
 - http://moztw.org/demo/audioplayer/
 - http://www.scottandrew.com/pub/html5audioplayer/

[Gyuyoung Kim]

Created attachment 77199 [details]
Patch

[Antonio Gomes]

Is it what other ports do?

(On the airport now, and can not check myself at the moment)

[Gyuyoung Kim]

(In reply to comment #2)
> Is it what other ports do?
> 
> (On the airport now, and can not check myself at the moment)

Yes, other port also tries to find mime type for the extension type. But, if it cannot find mime type, it just returns empty string. Then, if the other port's getMIMETypeForExtension() returns empty string, the getMediaMIMETypeForExtension() of MIMETypeRegistry.cpp finds a proper mime type in mediaMIMETypeMap() for the extension. (The mediaMIMETypeMap() is defined in MIMETypeRegistry.cpp).

In MIMETypeRegistryGtk.cpp

    String MIMETypeRegistry::getMIMETypeForExtension(const String &ext)
    {
        String s = ext.lower();
        const ExtensionMap *e = extensionMap;
        while (e->extension) {
            if (s == e->extension)
                return e->mimeType;
            ++e;
        }

        return String();
    }

In MIMETypeRegistryQt.cpp

    String MIMETypeRegistry::getMIMETypeForExtension(const String &ext)
    {
        String s = ext.lower();

        const ExtensionMap *e = extensionMap;
        while (e->extension) {
            if (s == e->extension)
                return e->mimeType;
            ++e;
        }

        return String();
    }

In MIMETypeRegistryWinCE.cpp

    String MIMETypeRegistry::getMIMETypeForExtension(const String &ext)
    {
        if (ext.isEmpty())
            return String();

        initMIMETypeEntensionMap();

        String result = mimetypeMap.get(ext.lower());
        if (result.isEmpty()) {
            result = mimeTypeForExtension(ext);
            if (!result.isEmpty())
                mimetypeMap.add(ext, result);
        }
        return result.isEmpty() ? "unknown/unknown" : result;
    }

[Eric Seidel (no email)]

Comment on attachment 77199 [details]
Patch

Tests should be layout tests.  Does EFL run the layout tests yet?

[Gyuyoung Kim]

(In reply to comment #4)
> (From update of attachment 77199 [details])
> Tests should be layout tests.  Does EFL run the layout tests yet?

Yes, right. WebKit EFL doesn't have layout test yet. But, we are preparing to contribute DRT for WebKit EFL.

[Gyuyoung Kim]

Should I remove the test sites in ChangeLog ?

[Gyuyoung Kim]

Created attachment 77375 [details]
Patch

Remove test sites in ChangeLog

[WebKit Commit Bot]

Comment on attachment 77375 [details]
Patch

Clearing flags on attachment: 77375

Committed r74625: <http://trac.webkit.org/changeset/74625>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.