Bug 5145

Summary:

Replace dlmalloc with tcmalloc

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

WebKit Misc.

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Do it (also move a bit more stuff into kxmlcore)	mjs: review-
improved version	sullivan: review+

Maciej Stachowiak

Reported 2005-09-26 23:51:53 PDT

Google's tcmalloc is fully threadsafe but just as fast as dlmalloc. This means we can avoid having two copies and won't need to follow weird threadsafety disciplines.

Attachments
Do it (also move a bit more stuff into kxmlcore) (717.02 KB, patch) 2005-09-27 00:19 PDT, Maciej Stachowiak	mjs: review-	Details Formatted Diff Diff
improved version (717.54 KB, patch) 2005-09-27 02:04 PDT, Maciej Stachowiak	sullivan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Maciej Stachowiak

Comment 1 2005-09-27 00:19:03 PDT

Created attachment 4057 [details] Do it (also move a bit more stuff into kxmlcore)

Maciej Stachowiak

Comment 2 2005-09-27 02:04:22 PDT

Created attachment 4060 [details] improved version I forgot to fall back to normal malloc in debug builds. Also fixed a few things that were ifdef'd wrong.

John Sullivan

Comment 3 2005-09-27 13:45:44 PDT

Comment on attachment 4060 [details] improved version I talked with mjs about this on IRC.

Note You need to log in before you can comment on or make changes to this bug.