Bug 51411

Summary:

Cleanup SVG code according to the webkit style rules 1

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, kling, rwlbuis, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Dirk Schulze

Reported 2010-12-21 11:46:19 PST

I plan to cleanup the SVG code according to the WebKit style rules. It's often hard to review patches, because our current reviewing rules force a commiter to cleanup existing code for every fix. check-webkit-style mentions style problems in 149 files in the SVG folder. I'd like to reduce it as much as possible.

Attachments
Patch (64.83 KB, patch) 2010-12-21 12:58 PST, Dirk Schulze	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2010-12-21 12:58:23 PST

Created attachment 77144 [details] Patch

Nikolas Zimmermann

Comment 2 2010-12-22 01:00:44 PST

Comment on attachment 77144 [details] Patch Excellent, thanks for starting this!

Dirk Schulze

Comment 3 2010-12-22 04:25:47 PST

Comment on attachment 77144 [details] Patch Clearing flags on attachment: 77144 Committed r74472: <http://trac.webkit.org/changeset/74472>

Dirk Schulze

Comment 4 2010-12-22 04:25:58 PST

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 5 2010-12-22 05:38:54 PST

http://trac.webkit.org/changeset/74472 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-by-character-004.html

Dirk Schulze

Comment 6 2010-12-22 05:55:24 PST

(In reply to comment #5) > http://trac.webkit.org/changeset/74472 might have broken GTK Linux 64-bit Debug > The following tests are not passing: > editing/selection/extend-by-character-004.html unlikely that it is this patch.

Note You need to log in before you can comment on or make changes to this bug.