Bug 51403

Summary: Clicking missing plug-in text does not show a sheet
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sullivan: review+

Description Anders Carlsson 2010-12-21 09:29:32 PST
Clicking missing plug-in text does not show a sheet
Comment 1 Anders Carlsson 2010-12-21 09:55:16 PST
Created attachment 77127 [details]
Patch
Comment 2 Early Warning System Bot 2010-12-21 10:09:39 PST
Attachment 77127 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7302086
Comment 3 John Sullivan 2010-12-21 10:22:42 PST
Comment on attachment 77127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77127&action=review

r+ assuming you've fixed the qt build.

> WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:398
> +    // Page UI client.

This FIXME should include a bug number.
Comment 4 Anders Carlsson 2010-12-21 10:30:15 PST
Committed r74418: <http://trac.webkit.org/changeset/74418>