Bug 5140

Summary:

CachedObject loading ignores charset from HTTP headers

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

VERIFIED FIXED

Severity:

Normal

CC:

dwood, maksim

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.rambler.ru/db/news/msg.html?mid=6614339

Attachments:

Description	Flags
test document	none
proposed patch	mjs: review-
proposed patch	mjs: review+

Alexey Proskuryakov

Reported 2005-09-26 11:44:29 PDT

khtml::Loader doesn't use a charset specified in Content-Type HTTP header. See the attached test case (accesses an external server)

Attachments
test document (363 bytes, text/html) 2005-09-26 11:45 PDT, Alexey Proskuryakov	no flags	Details
proposed patch (5.03 KB, patch) 2005-09-26 11:46 PDT, Alexey Proskuryakov	mjs: review-	Details Formatted Diff Diff
proposed patch (5.16 KB, patch) 2005-09-28 10:09 PDT, Alexey Proskuryakov	mjs: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2005-09-26 11:45:02 PDT

Created attachment 4047 [details] test document

Alexey Proskuryakov

Comment 2 2005-09-26 11:46:28 PDT

Created attachment 4048 [details] proposed patch

Alexey Proskuryakov

Comment 3 2005-09-26 11:48:42 PDT

Comment on attachment 4048 [details] proposed patch These files are formatted somewhat inconsistently; I tried to match what I saw in the nearest parts. Also, there were tabs in some places; I used spaces, as usual.

Maciej Stachowiak

Comment 4 2005-09-27 21:28:27 PDT

A setter method should be called "setCharset()", not just "charset()". Also, what will this code do if the HTTP headers include an invalid or unknown charset? Will the code that deletes the codec and fetches a new one leave you with no coded in this case?

Maciej Stachowiak

Comment 5 2005-09-27 21:29:05 PDT

Comment on attachment 4048 [details] proposed patch r- for setCharset() rename, and please make clear why blindly deleting the codec is OK, or fix it if it isn't.

Alexey Proskuryakov

Comment 6 2005-09-28 10:09:28 PDT

Created attachment 4079 [details] proposed patch Blindly deleting the codec was safe, because we were getting iso8859-1 for invalid charsets. But on a second thought, it was probably not such a good idea, because it didn't match what khtml::Decoder does for invalid charsets.

Maciej Stachowiak

Comment 7 2005-10-02 21:29:47 PDT

Comment on attachment 4079 [details] proposed patch r=me

Vicki Murley

Comment 8 2005-10-24 10:35:45 PDT

I'll commit this.

Alexey Proskuryakov

Comment 9 2005-10-24 21:25:22 PDT

Bug 5484 contains a fix for this patch.

Dan Wood

Comment 10 2005-11-21 10:49:14 PST

*** Bug 4879 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.