Summary: | [chromium] Media player styles being overridden | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Lacey <sjl> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, levin, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Steve Lacey
2010-12-20 15:56:26 PST
Created attachment 77053 [details]
Patch
Attachment 77053 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/css/mediaControlsChromium.css']" exit_code: 1
WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5]
WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Total errors found: 3 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 77053 [details]
Patch
Tabs in changelog (and this needs to be perfect to go through the commit queue).
Created attachment 77056 [details]
Patch
Comment on attachment 77056 [details] Patch Clearing flags on attachment: 77056 Committed r74381: <http://trac.webkit.org/changeset/74381> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 77056 [details]: fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. |