Summary: | [Qt] REGRESSION (r73535): tst_QWebPage fails | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, kenneth, kling, robert | ||||||||
Priority: | P1 | Keywords: | Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 50586 | ||||||||||
Attachments: |
|
Created attachment 79847 [details]
Patch
Comment on attachment 79847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79847&action=review > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:512 > - QVERIFY(contextMenu); > + QVERIFY(!contextMenu); > delete contextMenu; Deleting a null pointer is incorrect. Otherwise it worked for me locally. (In reply to comment #2) > (From update of attachment 79847 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79847&action=review > > > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:512 > > - QVERIFY(contextMenu); > > + QVERIFY(!contextMenu); > > delete contextMenu; > > Deleting a null pointer is incorrect. Otherwise it worked for me locally. Good point, though see https://bugs.webkit.org/show_bug.cgi?id=20357 The test is ensuring that contextMenu is a protected pointer. So attempting to delete it still tests that, I think. Could be confused though. Created attachment 81676 [details]
Patch
Comment on attachment 81676 [details] Patch Clearing flags on attachment: 81676 Committed r78135: <http://trac.webkit.org/changeset/78135> All reviewed patches have been landed. Closing bug. r78135 fixed a bug and show us a previously hidden fail: QFATAL : tst_QWebPage::inputMethodsTextFormat(Qt by) Received signal 15 FAIL! : tst_QWebPage::inputMethodsTextFormat(Qt by) Received a fatal error. Robert, could you file a new bug report on it, please? (In reply to comment #7) > r78135 fixed a bug and show us a previously hidden fail: > QFATAL : tst_QWebPage::inputMethodsTextFormat(Qt by) Received signal 15 > FAIL! : tst_QWebPage::inputMethodsTextFormat(Qt by) Received a fatal error. > > Robert, could you file a new bug report on it, please? That didn't crash for me on Qt 6.X here. (In reply to comment #8) > (In reply to comment #7) > > r78135 fixed a bug and show us a previously hidden fail: > > QFATAL : tst_QWebPage::inputMethodsTextFormat(Qt by) Received signal 15 > > FAIL! : tst_QWebPage::inputMethodsTextFormat(Qt by) Received a fatal error. > > > > Robert, could you file a new bug report on it, please? > > That didn't crash for me on Qt 6.X here. I did it yesterday by myself: https://bugs.webkit.org/show_bug.cgi?id=54217 |
Created attachment 76997 [details] GDB backtrace in debug mode QFATAL : tst_QWebPage::contextMenuCrash() Received signal 11 FAIL! : tst_QWebPage::contextMenuCrash() Received a fatal error. (GDB backtrace attached)