Bug 5132

Summary: SVG animations work in DrawTest but not WebKit/Safari
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Simple animating SVG.
none
Animation fix (and code cleanup) mjs: review+

Description Eric Seidel (no email) 2005-09-25 12:24:46 PDT
SVG animations work in DrawTest but not WebKit/Safari

Try loading the attached SVG in DrawTest (see it animate), then try it in Safari (see it fail to animate).
Comment 1 Eric Seidel (no email) 2005-09-25 12:25:31 PDT
Created attachment 4038 [details]
Simple animating SVG.
Comment 2 Eric Seidel (no email) 2005-09-25 12:49:00 PDT
I'm not invalidating the display in the WebView.  I need to figure out what's the proper way to do that via 
the render tree, and may need to make a new version of KCanvasViewQuartz which understands how to 
properly hook into that sort of thing.
Comment 3 Eric Seidel (no email) 2005-10-02 12:26:16 PDT
Created attachment 4151 [details]
Animation fix (and code cleanup)

Fixes animations in Safari/WebKit.  The fix is sorta "dumb" as we're ignoring
the passed dirty rect, and instead telling the entire render object to repaint.
Comment 4 Maciej Stachowiak 2005-10-02 21:41:32 PDT
Change looks ok to me, but I think passing the whole KCanvas area as the dirty rect is pretty serious. Still, 
this seems better than nothing.