Bug 5132

Summary: SVG animations work in DrawTest but not WebKit/Safari
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Simple animating SVG.
none
Animation fix (and code cleanup) mjs: review+

Eric Seidel (no email)
Reported 2005-09-25 12:24:46 PDT
SVG animations work in DrawTest but not WebKit/Safari Try loading the attached SVG in DrawTest (see it animate), then try it in Safari (see it fail to animate).
Attachments
Simple animating SVG. (9.18 KB, image/svg+xml)
2005-09-25 12:25 PDT, Eric Seidel (no email) 		no flags
Details
Animation fix (and code cleanup) (6.90 KB, patch)
2005-10-02 12:26 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-09-25 12:25:31 PDT
Created attachment 4038 [details] Simple animating SVG.
Eric Seidel (no email)
Comment 2 2005-09-25 12:49:00 PDT
I'm not invalidating the display in the WebView. I need to figure out what's the proper way to do that via the render tree, and may need to make a new version of KCanvasViewQuartz which understands how to properly hook into that sort of thing.
Eric Seidel (no email)
Comment 3 2005-10-02 12:26:16 PDT
Created attachment 4151 [details] Animation fix (and code cleanup) Fixes animations in Safari/WebKit. The fix is sorta "dumb" as we're ignoring the passed dirty rect, and instead telling the entire render object to repaint.
Maciej Stachowiak
Comment 4 2005-10-02 21:41:32 PDT
Change looks ok to me, but I think passing the whole KCanvas area as the dirty rect is pretty serious. Still, this seems better than nothing.
Note You need to log in before you can comment on or make changes to this bug.