Summary: | A corrupted counter tree is created when renderers are added to the tree bypassing RenderObject::addChild | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carol Szabo <carol> | ||||||||||
Component: | Layout and Rendering | Assignee: | Carol Szabo <carol> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bdakin, commit-queue, darin, eric, jamesr | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Carol Szabo
2010-12-17 12:12:51 PST
Created attachment 76903 [details]
Proposed Patch
Comment on attachment 76903 [details] Proposed Patch Clearing flags on attachment: 76903 Committed r74292: <http://trac.webkit.org/changeset/74292> All reviewed patches have been landed. Closing bug. My previous fix was reverted as it exposed other counter related problems such as the fact that sometimes renderers are moved around in the tree during removal of a renderer, causing a previously deleted counter to be recreated during the remove process. Thus I am reopening this bug in order to provide a more comprehensive fix. Created attachment 78042 [details]
Proposed Patch
This patch restores changes in my previous patch and takes care of the additional case when Renderers are moved in the Render tree from one place to another, especially when this happens inside the RenderObject::remove() call.
Created attachment 78164 [details]
Proposed patch. Fixed contributor name/e-mail in ChangeLog
Fixed contributor name/e-mail in ChangeLog
Created attachment 79230 [details]
Proposed Patch - Updated to reflect recent WebCore code restructuring.
Comment on attachment 79230 [details]
Proposed Patch - Updated to reflect recent WebCore code restructuring.
r=me
Comment on attachment 79230 [details] Proposed Patch - Updated to reflect recent WebCore code restructuring. Clearing flags on attachment: 79230 Committed r76859: <http://trac.webkit.org/changeset/76859> All reviewed patches have been landed. Closing bug. |