Bug 51269

Summary: Text area does not update when you arrow through a <select> in WebKit2
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: FormsAssignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, jhoneycutt
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
[PATCH] Fix andersca: review+

Description Brian Weinstein 2010-12-17 12:06:16 PST
Text area does not update when you arrow through a <select> in WebKit2.

<rdar://problem/8612853>
Comment 1 Brian Weinstein 2010-12-17 12:54:35 PST
Created attachment 76904 [details]
[PATCH] Fix
Comment 2 Anders Carlsson 2010-12-17 12:56:52 PST
Comment on attachment 76904 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76904&action=review

> WebKit2/UIProcess/WebPageProxy.h:104
> +class WebPageProxy : public APIObject, public WebPopupMenuProxy::Client {

Please remove public here.
Comment 3 Brian Weinstein 2010-12-17 13:05:36 PST
(In reply to comment #2)
> (From update of attachment 76904 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76904&action=review
> 
> > WebKit2/UIProcess/WebPageProxy.h:104
> > +class WebPageProxy : public APIObject, public WebPopupMenuProxy::Client {
> 
> Please remove public here.

I get a compile error in WebView.cpp if I do :-(. I'll land this patch as-is + a change to UIProcess/qt/WebPopupMenuProxyQt.cpp
Comment 4 Brian Weinstein 2010-12-17 13:09:17 PST
Landed in r74285.