Bug 51264

Summary: Interrupted accelerated animation can break later transitions
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarrin, dglazkov, gns, simon.fraser, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Step 1: some code cleanup
cmarrin: review+
Step 2: actual bug fix cmarrin: review+

Description Simon Fraser (smfr) 2010-12-17 10:42:11 PST
If we're waiting for an accelerated animation to start when leaving the page, the AnimationController can get stuck in a bad state that causes later transitions to fail.
Comment 1 Simon Fraser (smfr) 2010-12-17 10:42:52 PST
<rdar://problem/8767714>
Comment 2 Simon Fraser (smfr) 2010-12-17 11:00:12 PST
Created attachment 76893 [details]
Step 1: some code cleanup
Comment 3 Simon Fraser (smfr) 2010-12-17 12:11:51 PST
Created attachment 76901 [details]
Step 2: actual bug fix
Comment 4 WebKit Review Bot 2010-12-17 12:16:16 PST
Attachment 76901 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7242018
Comment 5 WebKit Review Bot 2010-12-17 12:19:56 PST
Attachment 76901 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7197011
Comment 6 Early Warning System Bot 2010-12-17 12:23:31 PST
Attachment 76901 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7318018
Comment 7 WebKit Review Bot 2010-12-17 12:33:02 PST
Attachment 76901 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7252020
Comment 8 Simon Fraser (smfr) 2010-12-17 12:33:44 PST
Comment on attachment 76901 [details]
Step 2: actual bug fix

This patch depends on the former, hence the build errors.
Comment 9 Build Bot 2010-12-17 12:34:22 PST
Attachment 76901 [details] did not build on win:
Build output: http://queues.webkit.org/results/7250016
Comment 10 WebKit Review Bot 2010-12-17 12:43:22 PST
Attachment 76901 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7205022