Summary: | Fix test failures where NULL GeolocationClient is provided | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Knottenbelt <jknotten> | ||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, jorlow, steveblock | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
John Knottenbelt
2010-12-17 08:26:26 PST
Created attachment 76884 [details]
Patch
Comment on attachment 76884 [details]
Patch
Pretty sure this is right and things are currently broken, so r=me. Steve please take a look tho.
LGTM The commit-queue encountered the following flaky tests while processing attachment 76884 [details]: http/tests/navigation/target-frame-from-window.html bug 51098 (author: ddkilzer@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 76884 [details] Patch Clearing flags on attachment: 76884 Committed r74274: <http://trac.webkit.org/changeset/74274> All reviewed patches have been landed. Closing bug. |