Bug 51217

Summary: Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Updated for new directory structure (WebKitTools -> Tools). none

Julie Parent
Reported 2010-12-16 15:44:02 PST
The num_runs parameter passed in to merge() is ignored by _remove_items_over_max_number_of_builds. Instead, JSON_RESULTS_MAX_BUILDS is always used, so the small version is not getting properly truncated.
Attachments
Patch (7.88 KB, patch)
2010-12-16 15:55 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Updated for new directory structure (WebKitTools -> Tools). (7.82 KB, patch)
2011-01-05 16:15 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2010-12-16 15:55:18 PST
Created attachment 76822 [details] Patch
Julie Parent
Comment 2 2011-01-05 16:15:49 PST
Created attachment 78059 [details] Updated for new directory structure (WebKitTools -> Tools).
Julie Parent
Comment 3 2011-01-05 17:08:33 PST
Since WebKitTools -> Tools I had to update this patch.
Tony Chang
Comment 4 2011-01-06 09:49:15 PST
Comment on attachment 78059 [details] Updated for new directory structure (WebKitTools -> Tools). Pro tip: "webkit-patch land-safely" when you already have r+ will allow you to upload a new patch without r?.
WebKit Commit Bot
Comment 5 2011-01-06 10:43:02 PST
Comment on attachment 78059 [details] Updated for new directory structure (WebKitTools -> Tools). Clearing flags on attachment: 78059 Committed r75166: <http://trac.webkit.org/changeset/75166>
WebKit Commit Bot
Comment 6 2011-01-06 10:43:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.