Bug 51193

Summary: IndexedDB: Support Date objects as keys.
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Hans Wennborg <hans>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, jorlow
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch jorlow: review+

Hans Wennborg
Reported 2010-12-16 09:28:53 PST
IndexedDB: Support Date objects as keys.
Attachments
Patch (21.14 KB, patch)
2010-12-16 09:47 PST, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Patch (21.88 KB, patch)
2010-12-17 04:45 PST, Hans Wennborg 		jorlow: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2010-12-16 09:47:12 PST
Created attachment 76777 [details] Patch
Jeremy Orlow
Comment 2 2010-12-16 10:12:31 PST
Comment on attachment 76777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76777&action=review > LayoutTests/storage/indexeddb/objectstore-basics.html:165 > + result = evalAndLog("store.add({x: new Date(), y: 'value'}, 'key')"); Maybe test passing in a specific date and verify it comes out as expected? > WebCore/storage/IDBKey.h:43 > + IDBKey* idbKey = new IDBKey(); Adopt it right away and store it in a ref ptr. .release() in the return
Hans Wennborg
Comment 3 2010-12-17 04:45:28 PST
(In reply to comment #2) > (From update of attachment 76777 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76777&action=review > > > LayoutTests/storage/indexeddb/objectstore-basics.html:165 > > + result = evalAndLog("store.add({x: new Date(), y: 'value'}, 'key')"); > > Maybe test passing in a specific date and verify it comes out as expected? Done (but doing it for the case where we use a Date as a key explicitly.) > > > WebCore/storage/IDBKey.h:43 > > + IDBKey* idbKey = new IDBKey(); > > Adopt it right away and store it in a ref ptr. .release() in the return Done.
Hans Wennborg
Comment 4 2010-12-17 04:45:56 PST
Created attachment 76868 [details] Patch
Jeremy Orlow
Comment 5 2010-12-17 07:03:36 PST
Comment on attachment 76868 [details] Patch r=me
Hans Wennborg
Comment 6 2010-12-17 07:11:08 PST
Committed r74266: <http://trac.webkit.org/changeset/74266>
Note You need to log in before you can comment on or make changes to this bug.