Bug 51166

Summary: ExecutableAllocator::cacheFlush should call sys_cache_control
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ddkilzer, ggaren, psolanki
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ggaren: review+, commit-queue: commit-queue-

Description Pratik Solanki 2010-12-15 22:55:24 PST 
cacheFlush() currently calls sys_icache_invalidate() and sys_dcache_flush. Instead we should just call sys_cache_control(kCacheFunctionPrepareForExecution,..).
Comment 1 Pratik Solanki 2010-12-15 22:55:57 PST 
<rdar://problem/8737284>
Comment 2 Pratik Solanki 2010-12-15 23:06:39 PST 
Created attachment 76737 [details]
Patch
Comment 3 Geoffrey Garen 2010-12-16 10:13:32 PST 
Comment on attachment 76737 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2010-12-16 10:15:08 PST 
Comment on attachment 76737 [details]
Patch

Rejecting attachment 76737 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76737]" exit_code: 2
Last 500 characters of output:
ailed to merge in the changes.
Patch failed at 0001 2010-12-16  Yury Semikhatsky  <yurys@chromium.org>

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at WebKitTools/Scripts/update-webkit line 132.

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2

Full output: http://queues.webkit.org/results/7094077
Comment 5 WebKit Commit Bot 2010-12-16 12:28:22 PST 
Comment on attachment 76737 [details]
Patch

Rejecting attachment 76737 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76737]" exit_code: 2
Last 500 characters of output:
ailed to merge in the changes.
Patch failed at 0001 2010-12-16  Yury Semikhatsky  <yurys@chromium.org>

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at WebKitTools/Scripts/update-webkit line 132.

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2

Full output: http://queues.webkit.org/results/7135083
Comment 6 Geoffrey Garen 2010-12-16 13:36:56 PST 
Committed revision 74210.