Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Benjamin (Ben) Kalman]

As in summary, Settings::editingBehaviorType() incorrectly returns mac (EditingMacBehavior) for gtk *when running tests*.  When running the gtk launcher (i.e. *not* in a test), it correctly returns unix (EditingUnixBehavior).

This is causing a confusing discrepancy in reported test results versus actual behavior, in at least editing/selection/extend-selection-home-end.html.  Note how the mac and gtk results are the same, when actually the gtk results should the same as the win ones (and this is caused by the check in SelectionController::positionForPlatform).

[Benjamin (Ben) Kalman]

Some helpful links:  see http://trac.webkit.org/browser/trunk/LayoutTests/platform/gtk/editing/selection/extend-selection-home-end-expected.txt (gtk results) and http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/editing/selection/extend-selection-home-end-expected.txt (mac results) are the same when they shouldn't be.

Rather, should be like http://trac.webkit.org/browser/trunk/LayoutTests/editing/selection/extend-selection-home-end-expected.txt

[Antonio Gomes]

I will look at this today.

[Antonio Gomes]

Created attachment 76841 [details]
patch v1 (committed r74269, r=mrobinson)

1) Make GTK+ reset its editing behavior to UNIX (default) instead of Mac in DumpRenderTree::resetDefaultsToConsistentValues
2) Removes gtk and win expectation files for editing/selection/extend-selection-home-end.html since they are equal to the cross platform result.

[Ryosuke Niwa]

Comment on attachment 76841 [details]
patch v1 (committed r74269, r=mrobinson)

LGTM.  Thanks for fixing this bug :)

[Antonio Gomes]

Comment on attachment 76841 [details]
patch v1 (committed r74269, r=mrobinson)

Clearing flags on attachment: 76841

Committed r74269: <http://trac.webkit.org/changeset/74269>

[WebKit Review Bot]

http://trac.webkit.org/changeset/74269 might have broken GTK Linux 64-bit Debug

[Antonio Gomes]

(In reply to comment #6)
> http://trac.webkit.org/changeset/74269 might have broken GTK Linux 64-bit Debug

Fixed in http://trac.webkit.org/changeset/74273 with the test rebasilined, and filed bug 51261 for the proper fix.