Bug 51126

Summary:

Semi-reproducible crash in ChunkedUpdateDrawingArea::paintIntoUpdateChunk closing a particular yahoo page

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mjs

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mjs: review+

Description Anders Carlsson 2010-12-15 12:06:26 PST

Semi-reproducible crash in ChunkedUpdateDrawingArea::paintIntoUpdateChunk closing a particular yahoo page

Comment 1 Anders Carlsson 2010-12-15 12:06:47 PST

<rdar://problem/8771219>

Comment 2 Anders Carlsson 2010-12-15 12:07:39 PST

Created attachment 76678 [details]
Patch

Comment 3 Maciej Stachowiak 2010-12-15 12:10:17 PST

Comment on attachment 76678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76678&action=review

> WebKit2/WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:97
> +        // The drawing area changed, return early.

This comment seems redundant with the code.

> WebKit2/WebProcess/WebPage/LayerBackedDrawingArea.cpp:98
> +        // The drawing area changed, return early.

This comment seems redundant with the code.

> WebKit2/WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:172
> +        // The drawing area changed, return early.

This comment seems redundant with the code.

Comment 4 Maciej Stachowiak 2010-12-15 12:10:32 PST

(r=me with those suggestions)

Comment 5 Anders Carlsson 2010-12-15 12:15:53 PST

Committed r74134: <http://trac.webkit.org/changeset/74134>