Summary: | WebKit2: Can't add files to an <input type=file> | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | webkit-ews | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | OS X 10.5 | ||||||||||||||
Attachments: |
|
Description
Sam Weinig
2010-12-14 19:02:49 PST
Created attachment 76618 [details]
Patch to test (DO NOT REVIEW)
Created attachment 76621 [details]
Also a test! (DO NOT REVIEW)
Created attachment 76683 [details]
Patch
Attachment 76683 [details] did not build on qt: Build output: http://queues.webkit.org/results/7158046 Created attachment 76684 [details]
Updated Patch
Comment on attachment 76684 [details] Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76684&action=review > WebKit2/Scripts/webkit2/messages.py:420 > + 'WebKit::WebOpenPanelParameters::Data': '"WebOpenPanelParameters.h"', I don't think this is needed. > WebKit2/Shared/WebOpenPanelParameters.cpp:52 > +{ I usually name the out parameter "result" here. > WebKit2/Shared/WebOpenPanelParameters.h:60 > + WebOpenPanelParameters(const Data&); Please make this explicit. > WebKitTools/MiniBrowser/mac/BrowserWindowController.m:540 > + printf("runOpenPanel callback\n"); Please remove this. Created attachment 77177 [details]
Tester
|