Bug 51051

Summary: commit-queue should upload failure diffs when tests flake
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, commit-queue, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch abarth: review+, eric: commit-queue-

Description Eric Seidel (no email) 2010-12-14 12:48:56 PST
commit-queue should upload failure diffs when tests flake
Comment 1 Eric Seidel (no email) 2010-12-14 12:53:17 PST
Created attachment 76560 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-14 12:54:29 PST
This is a first step.  This is going to need more patches.  But this is a very important feature to add to the flaky test reporting.  if this works out we can add this feature to other bots as well. :)
Comment 3 Adam Barth 2010-12-14 13:45:20 PST
I'll look at this tonight.
Comment 4 Eric Seidel (no email) 2010-12-15 11:22:53 PST
Created attachment 76672 [details]
Patch
Comment 5 Adam Barth 2010-12-15 11:30:36 PST
Comment on attachment 76672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76672&action=review

> WebKitTools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:449
> +        if hasattr(file_or_string, 'read'):
> +            return file_or_string

This is kind of a hack.

> WebKitTools/Scripts/webkitpy/tool/main.py:75
> +        self.filesystem = FileSystem()

Nice.  This has been a long time coming.
Comment 6 Eric Seidel (no email) 2010-12-15 13:39:27 PST
Comment on attachment 76672 [details]
Patch

Fixing a /diff/diffs/ typo, one sec.
Comment 7 Eric Seidel (no email) 2010-12-15 13:48:56 PST
Committed r74138: <http://trac.webkit.org/changeset/74138>