Summary: | Random crashes when running the layout tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | New Bugs | Assignee: | Dave Hyatt <hyatt> | ||||
Status: | VERIFIED FIXED | ||||||
Severity: | Major | CC: | eric | ||||
Priority: | P1 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
mitz
2005-09-21 22:45:15 PDT
It is enough to run WebKitTools/Scripts/run-webkit-tests dom/html/level2 in order to see the crash. Note that you need a Development build in order to see this. I can reproduce this crash pretty consistently if I run under MallocDebug, on HTML. I even caught it in the debugger, but it was not obvious what caused the failure - could have been a random memory trasher. I also found that the problem does not happen on a tree from 2005-09-20 9:00 AM. Now trying to narrow down to the change when it started. It's the tokenizer part of hyatt's recent change. Rolling just that one part in starts causing crashes in the layout tests. Created attachment 4012 [details]
Eliminate the pending stuff from the tokenizer
addPending did not check the destination buffer, so it was unsafe to just call
it. I decided to just bite the bullet and eliminate the pending concept all
together, since it is completely unnecessary to defer the processing of
whitespace.
Comment on attachment 4012 [details]
Eliminate the pending stuff from the tokenizer
Ready for a review. The layout tests no longer crash.
|