Bug 50908

Summary: Web Inspector: move scripts storage from ScriptsPanel to DebuggerModel
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
pfeldman: review-
Comments addressed. pfeldman: review+

Pavel Podivilov
Reported 2010-12-13 02:58:52 PST
Web Inspector: move scripts storage from ScriptsPanel to DebuggerModel
Attachments
Patch. (22.38 KB, patch)
2010-12-13 02:59 PST, Pavel Podivilov 		pfeldman: review-
DetailsFormatted DiffDiff
Comments addressed. (22.09 KB, patch)
2010-12-14 03:14 PST, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-12-13 02:59:37 PST
Created attachment 76363 [details] Patch.
Pavel Feldman
Comment 2 2010-12-13 04:07:02 PST
Comment on attachment 76363 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=76363&action=review > WebCore/inspector/front-end/DebuggerModel.js:34 > + this._scripts = {}; Where is it cleared?
Pavel Podivilov
Comment 3 2010-12-14 03:14:47 PST
Created attachment 76521 [details] Comments addressed.
Pavel Podivilov
Comment 4 2010-12-15 09:36:48 PST
Committed r74119: <http://trac.webkit.org/changeset/74119>
WebKit Review Bot
Comment 5 2010-12-15 10:33:22 PST
http://trac.webkit.org/changeset/74119 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: inspector/debugger-pause-on-breakpoint.html inspector/debugger-pause-on-debugger-statement.html inspector/debugger-pause-on-exception.html inspector/debugger-proto-property.html inspector/debugger-step-in.html inspector/debugger-step-out.html inspector/debugger-step-over.html inspector/debugger-suspend-active-dom-objects.html
Note You need to log in before you can comment on or make changes to this bug.