Bug 50908

Summary: Web Inspector: move scripts storage from ScriptsPanel to DebuggerModel
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
pfeldman: review-
Comments addressed. pfeldman: review+

Description Pavel Podivilov 2010-12-13 02:58:52 PST
Web Inspector: move scripts storage from ScriptsPanel to DebuggerModel
Comment 1 Pavel Podivilov 2010-12-13 02:59:37 PST
Created attachment 76363 [details]
Patch.
Comment 2 Pavel Feldman 2010-12-13 04:07:02 PST
Comment on attachment 76363 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=76363&action=review

> WebCore/inspector/front-end/DebuggerModel.js:34
> +    this._scripts = {};

Where is it cleared?
Comment 3 Pavel Podivilov 2010-12-14 03:14:47 PST
Created attachment 76521 [details]
Comments addressed.
Comment 4 Pavel Podivilov 2010-12-15 09:36:48 PST
Committed r74119: <http://trac.webkit.org/changeset/74119>
Comment 5 WebKit Review Bot 2010-12-15 10:33:22 PST
http://trac.webkit.org/changeset/74119 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
inspector/debugger-pause-on-breakpoint.html
inspector/debugger-pause-on-debugger-statement.html
inspector/debugger-pause-on-exception.html
inspector/debugger-proto-property.html
inspector/debugger-step-in.html
inspector/debugger-step-out.html
inspector/debugger-step-over.html
inspector/debugger-suspend-active-dom-objects.html