Bug 50852

Summary: Clean up assertion in Extensions3DOpenGL.cpp
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch darin: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-12-10 15:47:30 PST
There were a couple of mishaps about a new assertion added in Extensions3DOpenGL::ensureEnabled in r73806, r73809 and r73810. Darin pointed out that ASSERT_UNUSED is the preferred way of phrasing this assertion.
Attachments
Patch (1.39 KB, patch)
2010-12-10 16:03 PST, Kenneth Russell 		darin: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-12-10 16:03:57 PST
Created attachment 76276 [details] Patch
Darin Adler
Comment 2 2010-12-10 16:04:35 PST
Comment on attachment 76276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76276&action=review > WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:33 > +#include <wtf/Assertions.h> Are you sure you need this include? If there’s any other ASSERT in the entire file then it’s not needed.
Kenneth Russell
Comment 3 2010-12-10 17:23:08 PST
(In reply to comment #2) > (From update of attachment 76276 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76276&action=review > > > WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:33 > > +#include <wtf/Assertions.h> > > Are you sure you need this include? If there’s any other ASSERT in the entire file then it’s not needed. It seems no, even though it's the only ASSERT in the file. Will remove in landed version.
Kenneth Russell
Comment 4 2010-12-10 17:25:58 PST
Committed r73821: <http://trac.webkit.org/changeset/73821>
Note You need to log in before you can comment on or make changes to this bug.