Summary: | Some FileWriter progress events should be queued | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric U. <ericu> | ||||
Component: | DOM | Assignee: | Eric U. <ericu> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kinuko | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 44358 | ||||||
Attachments: |
|
Description
Eric U.
2010-12-10 14:42:15 PST
Created attachment 88499 [details]
Patch
Comment on attachment 88499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88499&action=review Not an extensive review as I'm in the middle of something but this should be addressed. > Source/WebCore/fileapi/FileWriter.h:110 > + FileWriterCompletionEventTask(PassRefPtr<FileWriter> fileWriter, FileError::ErrorCode code) Quick comment. This constructor should be private. This should only expose a static create method which returns a PassOwnPtr. Comment on attachment 88499 [details]
Patch
This seems fine.
Comment on attachment 88499 [details]
Patch
Should be fixed per levin's comemnt though.
(In reply to comment #4) > (From update of attachment 88499 [details]) > Should be fixed per levin's comemnt though. Thanks--I'll fix it before I land it. Committed r85556: <http://trac.webkit.org/changeset/85556> |