Summary: | commit-queue should report port/platform information when commenting on flaky test bugs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, galpeter, ojan, ossy, rgabor, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-12-10 13:15:09 PST
Created attachment 76246 [details]
Patch
Comment on attachment 76246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76246&action=review > WebKitTools/Scripts/webkitpy/common/system/platform.py:39 > + return platform.platform(aliased=1, terse=1) Heh, on my linux machine, this returns Linux-2.6.32-26-generic-pae-i686-with-glibc2.4. > WebKitTools/Scripts/webkitpy/tool/bot/flakytestreporter.py:103 > + bot_id_string = "Bot Id: %s " % (bot_id) if bot_id else "" > + return "%sPort: %s OS: %s" % (bot_id_string, self._tool.port().name(), self._tool.platform.display_name()) Nit: When I have lots of params, I normally switch to using the dictionary style replacements. Committed r73798: <http://trac.webkit.org/changeset/73798> This broken NRWT. When executive.py tries to import platform, it gets your new file instead of the system platform library. OK. I'll rename. http://trac.webkit.org/changeset/73798 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: editing/execCommand/4920488.html Committed r73804: <http://trac.webkit.org/changeset/73804> http://trac.webkit.org/changeset/73804 might have broken SnowLeopard Intel Release (Build) I had to remove webkitpy/common/system/platform.pyc manually from Qt EWS bot. Previously I had similar problem with mess pyc files after renaming, moving python files. We used to have code somewhere that cleaned up orphaned pyc files. Comment on attachment 76246 [details]
Patch
Clearing cq flag so that this patch won't appear on the review queue.
|