Bug 50839

Summary:

commit-queue should report port/platform information when commenting on flaky test bugs

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, galpeter, ojan, ossy, rgabor, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	tony: review+

Eric Seidel (no email)

Reported 2010-12-10 13:15:09 PST

commit-queue should report port/platform information when commenting on flaky test bugs

Attachments
Patch (10.61 KB, patch) 2010-12-10 13:20 PST, Eric Seidel (no email)	tony: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-12-10 13:20:49 PST

Created attachment 76246 [details] Patch

Tony Chang

Comment 2 2010-12-10 13:27:11 PST

Comment on attachment 76246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76246&action=review > WebKitTools/Scripts/webkitpy/common/system/platform.py:39 > + return platform.platform(aliased=1, terse=1) Heh, on my linux machine, this returns Linux-2.6.32-26-generic-pae-i686-with-glibc2.4. > WebKitTools/Scripts/webkitpy/tool/bot/flakytestreporter.py:103 > + bot_id_string = "Bot Id: %s " % (bot_id) if bot_id else "" > + return "%sPort: %s OS: %s" % (bot_id_string, self._tool.port().name(), self._tool.platform.display_name()) Nit: When I have lots of params, I normally switch to using the dictionary style replacements.

Eric Seidel (no email)

Comment 3 2010-12-10 13:42:20 PST

Committed r73798: <http://trac.webkit.org/changeset/73798>

Tony Chang

Comment 4 2010-12-10 14:20:38 PST

This broken NRWT. When executive.py tries to import platform, it gets your new file instead of the system platform library.

Eric Seidel (no email)

Comment 5 2010-12-10 14:21:57 PST

OK. I'll rename.

WebKit Review Bot

Comment 6 2010-12-10 14:26:30 PST

http://trac.webkit.org/changeset/73798 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: editing/execCommand/4920488.html

Eric Seidel (no email)

Comment 7 2010-12-10 14:31:12 PST

Committed r73804: <http://trac.webkit.org/changeset/73804>

WebKit Review Bot

Comment 8 2010-12-10 15:17:24 PST

http://trac.webkit.org/changeset/73804 might have broken SnowLeopard Intel Release (Build)

Csaba Osztrogonác

Comment 9 2010-12-11 02:25:35 PST

I had to remove webkitpy/common/system/platform.pyc manually from Qt EWS bot. Previously I had similar problem with mess pyc files after renaming, moving python files.

Adam Barth

Comment 10 2010-12-11 02:37:57 PST

We used to have code somewhere that cleaned up orphaned pyc files.

Ryosuke Niwa

Comment 11 2011-02-06 22:18:15 PST

Comment on attachment 76246 [details] Patch Clearing cq flag so that this patch won't appear on the review queue.

Note You need to log in before you can comment on or make changes to this bug.