Bug 50836

Summary: Move open and showModalDialog implementations from bindings into DOM class DOMWindow
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Darin Adler
Reported 2010-12-10 12:08:41 PST
Move open and showModalDialog implementations from bindings into DOM class DOMWindow
Attachments
Patch (54.53 KB, patch)
2010-12-10 12:20 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (54.53 KB, patch)
2010-12-10 14:19 PST, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-12-10 12:20:55 PST
Created attachment 76234 [details] Patch
WebKit Review Bot
Comment 2 2010-12-10 12:24:42 PST
Attachment 76234 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/js/JSDOMWindowCustom.cpp', u'WebCore/page/DOMWindow.cpp', u'WebCore/page/DOMWindow.h', u'WebCore/page/WindowFeatures.cpp', u'WebCore/page/WindowFeatures.h']" exit_code: 1 WebCore/page/WindowFeatures.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/page/WindowFeatures.cpp:228: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2010-12-10 12:28:56 PST
Attachment 76234 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6926037
Build Bot
Comment 4 2010-12-10 13:19:27 PST
Attachment 76234 [details] did not build on win: Build output: http://queues.webkit.org/results/6925046
Darin Adler
Comment 5 2010-12-10 14:19:37 PST
Created attachment 76259 [details] Patch
WebKit Review Bot
Comment 6 2010-12-10 14:21:54 PST
Attachment 76259 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/js/JSDOMWindowCustom.cpp', u'WebCore/page/DOMWindow.cpp', u'WebCore/page/DOMWindow.h', u'WebCore/page/WindowFeatures.cpp', u'WebCore/page/WindowFeatures.h']" exit_code: 1 WebCore/page/WindowFeatures.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/page/WindowFeatures.cpp:228: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 7 2010-12-10 18:20:25 PST
Committed r73829: <http://trac.webkit.org/changeset/73829>
Note You need to log in before you can comment on or make changes to this bug.