| Summary: | Move open and showModalDialog implementations from bindings into DOM class DOMWindow | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | DOM | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, dglazkov, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2010-12-10 12:08:41 PST
Created attachment 76234 [details]
Patch
Attachment 76234 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/js/JSDOMWindowCustom.cpp', u'WebCore/page/DOMWindow.cpp', u'WebCore/page/DOMWindow.h', u'WebCore/page/WindowFeatures.cpp', u'WebCore/page/WindowFeatures.h']" exit_code: 1
WebCore/page/WindowFeatures.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebCore/page/WindowFeatures.cpp:228: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 76234 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6926037 Attachment 76234 [details] did not build on win: Build output: http://queues.webkit.org/results/6925046 Created attachment 76259 [details]
Patch
Attachment 76259 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/js/JSDOMWindowCustom.cpp', u'WebCore/page/DOMWindow.cpp', u'WebCore/page/DOMWindow.h', u'WebCore/page/WindowFeatures.cpp', u'WebCore/page/WindowFeatures.h']" exit_code: 1
WebCore/page/WindowFeatures.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebCore/page/WindowFeatures.cpp:228: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r73829: <http://trac.webkit.org/changeset/73829> |