Bug 50831
| Summary: | RenderRubyBase::renderName() says “(anonymous)” | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | mitz |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
mitz
RenderRubyBase::renderName() always says that the renderer is anonymous. I don’t think a RRB can be anonymous. Certainly it’s not always anonymous.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
(In reply to mitz from comment #0)
> RenderRubyBase::renderName() always says that the renderer is anonymous. I
> don’t think a RRB can be anonymous. Certainly it’s not always anonymous.
Looked into 'RenderRubyBase.cpp' but don't find any 'anonymous' word or function name 'renderName'.
@Alan - is it something still need to be done or we can close this?
alan
(In reply to Ahmad Saleem from comment #1)
> (In reply to mitz from comment #0)
> > RenderRubyBase::renderName() always says that the renderer is anonymous. I
> > don’t think a RRB can be anonymous. Certainly it’s not always anonymous.
>
> Looked into 'RenderRubyBase.cpp' but don't find any 'anonymous' word or
> function name 'renderName'.
>
> @Alan - is it something still need to be done or we can close this?
This is about
ASCIILiteral renderName() const override { return "RenderRubyBase (anonymous)"_s; }
Ahmad Saleem
(In reply to zalan from comment #2)
> (In reply to Ahmad Saleem from comment #1)
> > (In reply to mitz from comment #0)
> > > RenderRubyBase::renderName() always says that the renderer is anonymous. I
> > > don’t think a RRB can be anonymous. Certainly it’s not always anonymous.
> >
> > Looked into 'RenderRubyBase.cpp' but don't find any 'anonymous' word or
> > function name 'renderName'.
> >
> > @Alan - is it something still need to be done or we can close this?
> This is about
> ASCIILiteral renderName() const override { return "RenderRubyBase
> (anonymous)"_s; }
So this is about 'test' expectation files showing (anonymous) in front of "RenderRubyBase"?
alan
(In reply to Ahmad Saleem from comment #3)
> (In reply to zalan from comment #2)
> > (In reply to Ahmad Saleem from comment #1)
> > > (In reply to mitz from comment #0)
> > > > RenderRubyBase::renderName() always says that the renderer is anonymous. I
> > > > don’t think a RRB can be anonymous. Certainly it’s not always anonymous.
> > >
> > > Looked into 'RenderRubyBase.cpp' but don't find any 'anonymous' word or
> > > function name 'renderName'.
> > >
> > > @Alan - is it something still need to be done or we can close this?
> > This is about
> > ASCIILiteral renderName() const override { return "RenderRubyBase
> > (anonymous)"_s; }
>
> So this is about 'test' expectation files showing (anonymous) in front of
> "RenderRubyBase"?
that and any other render tree dump type of utilities.