Bug 50814

Summary: [GTK] AX: implement isEnabled in DRT
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch proposal mrobinson: review+

Description Mario Sanchez Prada 2010-12-10 06:45:58 PST
DRT needs to be updated to correctly implement the isEnabled action so that
accessibility/aria-disabled.html can be uncommented in the skip list and run
Comment 1 Mario Sanchez Prada 2010-12-10 07:27:41 PST
Created attachment 76195 [details]
Patch proposal
Comment 2 Martin Robinson 2010-12-10 07:38:03 PST
Comment on attachment 76195 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=76195&action=review

Nice patch! Please incorporate the small cleanup suggested below before landing.

> WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:382
> +    bool result = static_cast<bool>(atk_state_set_contains_state(stateSet.get(), stateType));
> +
> +    return result;

This can just be: return atk_state_set_contains_state(stateSet.get(), stateType)
Comment 3 Mario Sanchez Prada 2010-12-10 08:54:02 PST
Committed r73732: <http://trac.webkit.org/changeset/73732>