Bug 50814

Summary: [GTK] AX: implement isEnabled in DRT
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch proposal mrobinson: review+

Mario Sanchez Prada
Reported 2010-12-10 06:45:58 PST
DRT needs to be updated to correctly implement the isEnabled action so that accessibility/aria-disabled.html can be uncommented in the skip list and run
Attachments
Patch proposal (3.60 KB, patch)
2010-12-10 07:27 PST, Mario Sanchez Prada 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2010-12-10 07:27:41 PST
Created attachment 76195 [details] Patch proposal
Martin Robinson
Comment 2 2010-12-10 07:38:03 PST
Comment on attachment 76195 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=76195&action=review Nice patch! Please incorporate the small cleanup suggested below before landing. > WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:382 > + bool result = static_cast<bool>(atk_state_set_contains_state(stateSet.get(), stateType)); > + > + return result; This can just be: return atk_state_set_contains_state(stateSet.get(), stateType)
Mario Sanchez Prada
Comment 3 2010-12-10 08:54:02 PST
Committed r73732: <http://trac.webkit.org/changeset/73732>
Note You need to log in before you can comment on or make changes to this bug.