Bug 50732

Summary:

Allow disabling of font smoothing in compositing layers to be overridden by style

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, dglazkov, eric, mitz, simon.fraser, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

50733

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	mitz: review+

Description Simon Fraser (smfr) 2010-12-08 20:36:13 PST

It should be possible for a web developer to override the non-smoothed fonts in compositing layers via CSS, which they might want to do if they know the layer background is opaque.

Comment 1 Simon Fraser (smfr) 2010-12-08 20:38:22 PST

<rdar://problem/8747953>

Comment 2 Simon Fraser (smfr) 2010-12-13 18:17:37 PST

Created attachment 76479 [details]
Patch

Comment 3 WebKit Review Bot 2010-12-13 18:31:56 PST

Attachment 76479 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6960105

Comment 4 Simon Fraser (smfr) 2010-12-13 18:37:07 PST

Created attachment 76480 [details]
Patch

Comment 5 Eric Seidel (no email) 2010-12-13 20:52:18 PST

Attachment 76480 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7048009

Comment 6 Eric Seidel (no email) 2010-12-13 21:12:11 PST

Attachment 76480 [details] did not build on mac:
Build output: http://queues.webkit.org/results/6901116

Comment 7 Eric Seidel (no email) 2010-12-14 01:01:22 PST

Attachment 76480 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7023110

Comment 8 Simon Fraser (smfr) 2010-12-14 11:35:50 PST

Created attachment 76551 [details]
Patch

Comment 9 Eric Seidel (no email) 2010-12-14 12:05:34 PST

Attachment 76551 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6944123

Comment 10 Eric Seidel (no email) 2010-12-14 13:19:24 PST

Attachment 76551 [details] did not build on mac:
Build output: http://queues.webkit.org/results/6921149

Comment 11 Simon Fraser (smfr) 2010-12-14 15:15:52 PST

Created attachment 76579 [details]
Patch

Comment 12 Simon Fraser (smfr) 2010-12-15 13:29:01 PST

Dan has a valuable point here. This patch (and existing webkit, actually), allows CSS to turn on font smoothing when the user may have disabled it system-wide via the System Preferences.

However, that issue is not new with this patch. We should address is separately.

Comment 13 mitz 2010-12-15 13:48:25 PST

Comment on attachment 76579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76579&action=review

Why isn’t the Font code using the new GraphicsContext methods? I choose to r- what I don’t understand :)

> WebCore/ChangeLog:39
> +2010-12-13  Simon Fraser  <simon.fraser@apple.com>
> +
> +        GraphicsContextPrivate.h was removed. Nuke it from the project.
> +        
> +        * WebCore.xcodeproj/project.pbxproj:
> +

Old change log entry

Comment 14 Simon Fraser (smfr) 2010-12-15 13:48:52 PST

(In reply to comment #12)
> Dan has a valuable point here. This patch (and existing webkit, actually), allows CSS to turn on font smoothing when the user may have disabled it system-wide via the System Preferences.

Testing shows that this is not actually true, before or after this patch. The System Preference setting trumps all.

Comment 15 Simon Fraser (smfr) 2010-12-15 15:37:06 PST

http://trac.webkit.org/changeset/74151