Bug 50682

Summary: feColorMatrix calculation for type matrix does not incorporate channel offsets
Product: WebKit Reporter: Pieter Senster <psenster>
Component: SVGAssignee: Nobody <webkit-unassigned>
Severity: Minor CC: commit-queue, krit, zherczeg, zimmermann
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Testcase for feColorMatrix using offsets
Proposed patch none

Description Pieter Senster 2010-12-08 05:30:20 PST
In FEColorMatrix.cpp, the 'offset' matrix values (the fifth column in the matrix) are not used to calculate the result of a color transformation. The correct matrix multiplication is stated here: http://www.w3.org/TR/SVG/filters.html#feColorMatrixElement.
Comment 1 Pieter Senster 2010-12-08 08:06:05 PST
Created attachment 75906 [details]
Testcase for feColorMatrix using offsets
Comment 2 Pieter Senster 2010-12-09 03:18:02 PST
Created attachment 76037 [details]
Proposed patch
Comment 3 Nikolas Zimmermann 2010-12-09 04:10:59 PST
Looks good to me, adding Dirk to review.
Comment 4 Dirk Schulze 2010-12-10 06:37:08 PST
Comment on attachment 76037 [details]
Proposed patch

r=me. Sorry for the late response.
Comment 5 WebKit Commit Bot 2010-12-14 03:03:10 PST
Comment on attachment 76037 [details]
Proposed patch

Clearing flags on attachment: 76037

Committed r74010: <http://trac.webkit.org/changeset/74010>
Comment 6 WebKit Commit Bot 2010-12-14 03:03:15 PST
All reviewed patches have been landed.  Closing bug.