Bug 50668 – Bopomofo should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp

• Component: Text
• Status: RESOLVED FIXED

[Koan-Sin Tan]

Bopomofo, which mainly used in Taiwan for educational purposes, is used to note the pronunciation of Han glyphs. It should be considered part of CJK Ideographs

[Koan-Sin Tan]

Created attachment 75875 [details]
let Bopomofo, Bopomofo Extended, and tone marks be part of CJK

[Alexey Proskuryakov]

Does this have any observable effect? If so, this needs a test case - and otherwise, this change may not need to be made.

[Koan-Sin Tan]

(In reply to comment #2)
> Does this have any observable effect? If so, this needs a test case - and otherwise, this change may not need to be made.

Yes, pretty observable when you got certain "broken" fonts. I have made a test case, but the problem is to show the test case you need Microsoft copyrighted fonts, such as DFKai-SB [1].  I cannot find redistributable fonts which have the same problem yet.

[1] http://www.microsoft.com/typography/fonts/font.aspx?FMID=838

[Koan-Sin Tan]

Created attachment 75992 [details]
a test page to show this bug 

To see this page properly, you need 'resources/kaiu.ttf', which is not redistributable. However, it came with every Windows system :-)

[Koan-Sin Tan]

Created attachment 75994 [details]
a snapshot picture to show what's wrong

those Bopomofo glyphs in red circles should be rotated 90 degrees counterclockwise.

[Alexey Proskuryakov]

> I have made a test case, but the problem is to show the test case you need Microsoft copyrighted fonts, such as DFKai-SB [1].  I cannot find redistributable fonts which have the same problem yet.

That's a a good explanation - it should go into ChangeLog, as the patch won't successfully land with OOPS.

+    // 0x2C7 Caron, Mandrin Chinese 3rd Tone

Typo: should be Mandarin.

Note that I do not intend to do final review on  this patch - perhaps Dan (already CC'ed) would like to take a look.

[Koan-Sin Tan]

Created attachment 76007 [details]
Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK

fix typo and add description of test case as suggested by Alexey

[Eric Seidel (no email)]

Comment on attachment 76007 [details]
Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK

OK.

[WebKit Review Bot]

Comment on attachment 76007 [details]
Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK

Clearing flags on attachment: 76007

Committed r73706: <http://trac.webkit.org/changeset/73706>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/73706 might have broken GTK Linux 32-bit Debug