| Summary: | GeneratedImage::drawPattern() crashes when it fails to create ImageBuffer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yong Li <yong.li.webkit> | ||||
| Component: | Images | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, staikos, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 75822 [details]
the patch
Comment on attachment 75822 [details]
the patch
I silently drawing nothing the most useful behavior? Do callers need to know nothing was drawn?
Attachment 75822 [details] did not pass style-queue:
Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > (From update of attachment 75822 [details]) > I silently drawing nothing the most useful behavior? Do callers need to know nothing was drawn? ImageBuffer::create() rarely fails currently. Probably the best solution is never let ImageBuffer::create() fail, and let it do some alternative job when it cannot create platform resource. Attachment 75822 [details] did not pass style-queue:
Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 75822 [details] did not pass style-queue:
Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 75822 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061
Died at WebKitTools/Scripts/update-webkit line 132.
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 75822 [details] the patch Rejecting patch 75822 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6730115 The commit-queue encountered the following flaky tests while processing attachment 75822 [details]: webarchive/test-link-rel-icon.html http/tests/loading/basic-credentials-sent-automatically.html Please file bugs against the tests. These tests were authored by beidson@apple.com and ddkilzer@webkit.org. The commit-queue is continuing to process your patch. Comment on attachment 75822 [details] the patch Clearing flags on attachment: 75822 Committed r73622: <http://trac.webkit.org/changeset/73622> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/73622 might have broken GTK Linux 64-bit Debug |
void GeneratedImage::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransform, const FloatPoint& phase, ColorSpace styleColorSpace, CompositeOperator compositeOp, const FloatRect& destRect) { ... OwnPtr<ImageBuffer> imageBuffer = ImageBuffer::create(adjustedSize); ASSERT(imageBuffer.get()); Why do we assert here? ImageBuffer::create() is allowed to return 0: static PassOwnPtr<ImageBuffer> create(const IntSize& size, ImageColorSpace colorSpace = DeviceRGB) { bool success = false; OwnPtr<ImageBuffer> buf(new ImageBuffer(size, colorSpace, success)); if (success) return buf.release(); return 0; }