| Summary: | Fix compilation of core web audio files on Windows | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||
| Component: | WebCore Misc. | Assignee: | Kenneth Russell <kbr> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, crogers, dglazkov, fishd, jamesr, levin | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Kenneth Russell
2010-12-06 17:30:12 PST
Created attachment 75764 [details]
Patch
Hi Ken, this looks fine to me. I agree that pulling out the methods from AudioParam.h to AudioParam.cpp is the right thing to do. Created attachment 75765 [details]
Patch
Comment on attachment 75765 [details]
Patch
Recalculated M_LN2 and removed name of argument to AudioParam::setValue in header based on offline feedback from Dave Levin.
Comment on attachment 75765 [details] Patch Rejecting patch 75765 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: rs.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/CallData.o /Projects/CommitQueue/JavaScriptCore/runtime/CallData.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/BooleanPrototype.o /Projects/CommitQueue/JavaScriptCore/runtime/BooleanPrototype.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (18 failures) Full output: http://queues.webkit.org/results/6751092 Comment on attachment 75765 [details]
Patch
That commit queue failure looks like a configuration problem on the machine. Retrying.
Comment on attachment 75765 [details] Patch Rejecting patch 75765 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6802070 Comment on attachment 75765 [details]
Patch
It looks like the commit queue is stuck. I'm going to land this by hand.
Committed r73458: <http://trac.webkit.org/changeset/73458> |