Bug 50603

Summary: Fix compilation of core web audio files on Windows
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebCore Misc.Assignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, crogers, dglazkov, fishd, jamesr, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch levin: review+

Kenneth Russell
Reported 2010-12-06 17:30:12 PST
While compiling the core files for the web audio API and implementation on Windows, several compilation issues were encountered, mostly related to math constants and functions.
Attachments
Patch (18.33 KB, patch)
2010-12-06 17:44 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (18.32 KB, patch)
2010-12-06 17:58 PST, Kenneth Russell 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-12-06 17:44:20 PST
Created attachment 75764 [details] Patch
Chris Rogers
Comment 2 2010-12-06 17:54:45 PST
Hi Ken, this looks fine to me. I agree that pulling out the methods from AudioParam.h to AudioParam.cpp is the right thing to do.
Kenneth Russell
Comment 3 2010-12-06 17:58:12 PST
Created attachment 75765 [details] Patch
Kenneth Russell
Comment 4 2010-12-06 17:59:24 PST
Comment on attachment 75765 [details] Patch Recalculated M_LN2 and removed name of argument to AudioParam::setValue in header based on offline feedback from Dave Levin.
WebKit Commit Bot
Comment 5 2010-12-06 18:35:38 PST
Comment on attachment 75765 [details] Patch Rejecting patch 75765 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: rs.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/CallData.o /Projects/CommitQueue/JavaScriptCore/runtime/CallData.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/BooleanPrototype.o /Projects/CommitQueue/JavaScriptCore/runtime/BooleanPrototype.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (18 failures) Full output: http://queues.webkit.org/results/6751092
Kenneth Russell
Comment 6 2010-12-06 18:39:05 PST
Comment on attachment 75765 [details] Patch That commit queue failure looks like a configuration problem on the machine. Retrying.
WebKit Commit Bot
Comment 7 2010-12-06 20:48:56 PST
Comment on attachment 75765 [details] Patch Rejecting patch 75765 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6802070
Kenneth Russell
Comment 8 2010-12-07 13:39:06 PST
Comment on attachment 75765 [details] Patch It looks like the commit queue is stuck. I'm going to land this by hand.
Kenneth Russell
Comment 9 2010-12-07 13:45:25 PST
Committed r73458: <http://trac.webkit.org/changeset/73458>
Note You need to log in before you can comment on or make changes to this bug.