Summary: | REGRESSION (r73065?): A regex no longer works | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Francisco Tolmasky <tolmasky> | ||||||||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | antoine.mercadal, barraclough, ggaren, klesper, msaboff | ||||||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac (Intel) | ||||||||||||
OS: | OS X 10.6 | ||||||||||||
Attachments: |
|
Description
Francisco Tolmasky
2010-12-06 09:20:05 PST
*** Bug 50673 has been marked as a duplicate of this bug. *** Created attachment 76077 [details]
Patch to fix linking of parentheses tail code.
+ Changed the handling of adjacent parentheses backtracks in two ways. + First, only outer most paren backtracks default to back tracking + to the "next character" looping code. Second, added a jump around + backtracks that fall through to the next backtrack where the + second backtrack has some greedy processing before the backtracking + from outside the parentheses code. + https://bugs.webkit.org/show_bug.cgi?id=50570 A somewhat more readable and common format would be: + REGRESSION (r73065): A regex no longer works + https://bugs.webkit.org/show_bug.cgi?id=50570 + + Changed the handling of adjacent parentheses backtracks in two ways. + First, only outer most paren backtracks default to back tracking + to the "next character" looping code. Second, added a jump around + backtracks that fall through to the next backtrack where the + second backtrack has some greedy processing before the backtracking + from outside the parentheses code. Created attachment 76089 [details]
New Patch with redundant {increment/decrement}ParenNestingLevel calls
Hi Michael, (1) please fix the change log comment per alexey's request. (2) please remove the superfluous indent. (3) please switch JumpList -> Jump. (4) please comment the new check, with a simple example. cheers, G. Created attachment 76111 [details]
Patch addressing reviewers comments
Note that I also cleaned up ALL of the extra whitespace in the file JavaScriptCore/yarr/RegexJIT.cpp. Therefore the resulting patch is large.
Committed r73640: <http://trac.webkit.org/changeset/73640> |