Bug 50569

Summary: WebKit based browsers no longer ftp in coldfusion application
Product: WebKit Reporter: Michael McGuire <mcguire>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: adamcrispin843, ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: https://utk.tera.tennessee.edu/ramses/de_attachments.cfm
Attachments:
Description Flags
This is the file upload page code none

Michael McGuire
Reported 2010-12-06 08:52:35 PST
After Safari 5.0 all webkit based browsers no longer ftp files in our research proposal application on OS X. Since all other bowsers do, as well as Safari on W7 it is a major problem for us. A typical error page is enclosed. From: System Errors <maceo@EMAIL.UNC.EDU> Reply-To: TERA Support <TERASUPPORT@LISTSERV.UTK.EDU> Date: Sun, 5 Dec 2010 20:45:28 -0500 To: <TERASUPPORT@LISTSERV.UTK.EDU> Subject: [TERASUPPORT] utk.tera.tennessee.edu ERROR Remote Address: 69.245.5.231 User Affected: Jinyuan Sun PID: 00280818 Onyen: jysun Email: JYSUN@tennessee.edu Browser: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_5; en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.215 Safari/534.10 Date and Time: 08:45:17 on 12/05/2010 Error Page: /ramses/proc/validate_file_upload2.cfm? Referrer: https://utk.tera.tennessee.edu/ramses/de_attachments.cfm?NoCache=1291599880802 Message: Java heap space Diagnostics: Java heap space null The error occurred on line -1. Root Cause: java.lang.OutOfMemoryError: Java heap space Extended Info: Form Fields: FILE,FILECHECK,DOCTYPE,RELATED_ID,ATTACH_AREA,UPLOAD_TYPE,ATTACH_PRIVS FILE = E:\JRun4\servers\UTK\SERVER-INF\temp\cfusion.war-tmp\neotmp511437264288785652.tmp FILECHECK = C:\fakepath\3Year Budget.xls DOCTYPE = BGT RELATED_ID = 29099 ATTACH_AREA = Proposal UPLOAD_TYPE = IPF ATTACH_PRIVS = Admin Award Dept IPF Approver,Admin Office,All IPF Parties,Certifying Investigator,IPF Creator,Lead PI Appt Dept IPF Approver,Lead PI Only,Research Team struct admin 0 admin_document_access 0 admin_global 0 admin_office [empty string] admin_office_certain_access [empty string] admin_office_global [empty string] admin_oris [empty string] admin_osr_award 0 admin_osr_award_pre 0 admin_person_mgmt 0 admin_sponsor_mgmt 0 auth_dept 0 auth_method [empty string] award_filter_sort a.dollars_feed_date desc bshell struct DATACACHE struct BSWIN_028076611063443124 struct T14 struct ADMIN_OFFICE UTK Office of Research AWARD_ADMIN_DEPT UTK-Electrical Engr AWARD_ADMIN_DEPT_NO U013425040 ID 29099 OWNER_PID 00280818 STATUS Unsubmitted T46 struct DB_USERS_ID 162 ID 4089 SESSION_DTS 2010-12-05 20:38:58.98 SESSION_NUM CFID=79162&CFTOKEN=29935887 TEMP struct T14 struct ADMIN_OFFICE UTK Office of Research AWARD_ADMIN_DEPT UTK-Electrical Engr AWARD_ADMIN_DEPT_NO U013425040 ID 29099 OWNER_PID 00280818 STATUS Unsubmitted INIT True PAGEFIELDS struct DE_ATTACHMENTSCFM struct TID14 ID, STATUS, ADMIN_OFFICE, OWNER_PID, AWARD_ADMIN_DEPT_NO, AWARD_ADMIN_DEPT TID46 ID, DB_USERS_ID, SESSION_NUM, SESSION_DTS PAGEVARS struct BSWIN_028076611063443124 struct DE_ABSTRACTCFM struct BSHELLCURRENTPAGE de_abstract.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 932|comma932 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_APPROVING_DEPTSCFM struct AUTHORIZE 1 BSHELLCURRENTPAGE de_approving_depts.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 932|comma932 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_ATTACHMENTSCFM struct ATTACHERROR [empty string] ATTACHFILTER All|slashesAll BSHELLCURRENTPAGE de_attachments.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 1038|comma1038 BSHELL_DOC_WIDTH 1280|comma1280 CBST FileTypePlate DELETERECID [empty string] DOWNLOADRECID [empty string] MODIFYFILETYPE [empty string] NOCACHE 1291599880802 SETFILETYPE [empty string] WINNAME BSWin_028076611063443124 DE_BENEFITS_NCCFM struct BSHELLCURRENTPAGE de_benefits_nc.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 1231|comma1231 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_BUDGETCFM struct BSHELLCURRENTPAGE de_budget.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 1350|comma1350 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 ERROR 1 WINNAME BSWin_028076611063443124 DE_COICFM struct BSHELLCURRENTPAGE de_coi.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 947|comma947 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_EXPORT_CONTROLCFM struct BSHELLCURRENTPAGE de_export_control.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 1138|comma1138 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_GENERAL_INFOCFM struct BSHELLCURRENTPAGE de_general_info.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 1619|comma1619 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 ERROR 1 NEW 1 WINNAME BSWin_028076611063443124 DE_INTEL_PROPCFM struct BSHELLCURRENTPAGE de_intel_prop.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 1331|comma1331 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_INVCFM struct BSHELLCURRENTPAGE de_inv.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 932|comma932 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_RESEARCH_SUBJECTSCFM struct BSHELLCURRENTPAGE de_research_subjects.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 1450|comma1450 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_SPONSORED_ACTIVITIESCFM struct BSHELLCURRENTPAGE de_sponsored_activities.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 1347|comma1347 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 DE_SUBCONTRACTORSCFM struct BSHELLCURRENTPAGE de_subcontractors.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 932|comma932 BSHELL_DOC_WIDTH 1280|comma1280 CFID 79162 CFTOKEN 29935887 WINNAME BSWin_028076611063443124 INDEX_AUTHCFM struct BSHELLCURRENTPAGE index_auth.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 855|comma855 BSHELL_DOC_WIDTH 1280|comma1280 WINNAME BSWin_028076611063443124 MANAGE_AFFILIATEDCFM struct BSHELLCURRENTPAGE manage_affiliated.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_028076611063443124 BSHELL_DOC_HEIGHT 831|comma831 BSHELL_DOC_WIDTH 1280|comma1280 WINNAME BSWin_028076611063443124 BSWIN_07518235247116536 struct MANAGE_AFFILIATEDCFM struct BSHELLCURRENTPAGE manage_affiliated.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_07518235247116536 BSHELL_DOC_HEIGHT 831|comma831 BSHELL_DOC_WIDTH 1280|comma1280 SECTION submitted WINNAME BSWin_07518235247116536 PROP_ROUTING_STATUSCFM struct BSHELLCURRENTPAGE prop_routing_status.cfm BSHELLTEMPLATE _ignore BSHELLWIN BSWin_07518235247116536 BSHELL_DOC_HEIGHT 1106|comma1106 BSHELL_DOC_WIDTH 1280|comma1280 PROP_ID 28591 WINNAME BSWin_07518235247116536 PRIVLOGDATA 08:30:38: Check Workflow Section[14/29099] &nbsp;&nbsp;&nbsp;Privilege request failed at :Check if Proposal Screen&nbsp;&nbsp;&nbsp;Privilege request failed at :Check other Screens&nbsp;&nbsp;&nbsp;Result:False08:30:38: Check Attachment Add[1/29099] &nbsp;&nbsp;&nbsp;Result:true08:31:21: Check Workflow Section[14/29099] &nbsp;&nbsp;&nbsp;Privilege request failed at :Check if Proposal Screen&nbsp;&nbsp;&nbsp;Privilege request failed at :Check other Screens&nbsp;&nbsp;&nbsp;Result:False08:31:21: Check Attachment Add[1/29099] &nbsp;&nbsp;&nbsp;Result:true08:38:36: Check Workflow Section[14/29099] &nbsp;&nbsp;&nbsp;Privilege request failed at :Check if Proposal Screen&nbsp;&nbsp;&nbsp;Privilege request failed at :Check other Screens&nbsp;&nbsp;&nbsp;Result:False08:38:36: Check Attachment Add[1/29099] &nbsp;&nbsp;&nbsp;Result:true08:44:44: Check Workflow Section[14/29099] &nbsp;&nbsp;&nbsp;Privilege request failed at :Check if Proposal Screen&nbsp;&nbsp;&nbsp;Privilege request failed at :Check other Screens&nbsp;&nbsp;&nbsp;Result:False08:44:44: Check Attachment Add[1/29099] &nbsp;&nbsp;&nbsp;Result:true SESSIONVARS struct ACCESSUPDATERECID [empty string] CURRENTPAGE [empty string] LASTPAGE de_attachments.cfm LASTPAGEPROCESS BSWin_028076611063443124 UPDATEPRIVS [empty string] WID [empty string] cfid 79162 cftoken 29935887 dept_no U013425040 dept_referrer general_info dest_page [empty string] email JYSUN@tennessee.edu error Please enter begin and end dates for both the initial and total periods filter_sort date_submitted desc fname Jinyuan funding_referrer general_info1 httpreferrer /ramses/de_attachments.cfm?NoCache=1291599880802 ir_wsauth [empty string] js_field_set_page total_budget2 lname Sun onyen jysun person_referrer investigator phone 8659744398 pid 00280818 prop_id 29099 qs [empty string] referrer general_info returnpage [empty string] sessionid RAMSES_UTK_79162_29935887 somid [empty string] tmp_abstract Fast and secure access to patients’ records helps save lives with more proper treatment in emergency situations. Therefore, anywhere-any time-accessible online healthcare or medical system plays a vital role in daily life. Advances in (wireless) communications and computing technologies have lent great forces to the migration of healthcare system from the paper-based to the EHR (electronic health record)-based, giving rise to increased efficiency in human operations, reduced storage costs and medical errors, improved data availability and sharing, etc. Unfortunately, such convenience also comes with concerns, which should be carefully addressed. For example, medical or health record privacy is a major concern to the patients and be- comes the major barrier in the deployment of the EHR-based healthcare systems. It is observed that privacy and security breaches have already penetrated every aspect of our activities and living environment including healthcare, financial, voting, e-commerce, military, etc. Thus, there is an urgent need for the development of architectures assuring privacy and security that are imperative to safeguarding confidential information wherever it digitally resides. Despite the paramount importance of privacy and security, little progress has been introduced by researchers in the design of security and privacy architectures for EHR-based health- care system. In particular, two extremely critical issues are rarely touched in the research realm: health information privacy and sharing. Without privacy guarantee, health information may be leaked to cause life-changing consequences such as difficulties in obtaining insurance or employment, being discriminated for having certain disease, etc. Most importantly, healthcare systems lacking privacy guarantees cannot be psychologically accepted by the public and hence are not likely to be advocated and implemented. Moreover, without health information sharing in a secure and private manner, cross-organizational collaborations indis- pensable for patient treatment and clinical research will be rendered difficult, if not impossible. Therefore, health information privacy and sharing are the cornerstones to achieving a functional, secure, and private EHR-based healthcare system, and will be the focus of this proposal. tmp_academic_buyout 0 tmp_additional_equipment [empty string] tmp_additional_personnel [empty string] tmp_additional_resources_explain [empty string] tmp_additional_resources_needed 0 tmp_additional_software NULL tmp_additional_space [empty string] tmp_additional_space_mhra [empty string] tmp_affiliate_code_values [empty string] tmp_affiliated_dept [empty string] tmp_affiliated_dept_no [empty string] tmp_animal_subjects 0 tmp_arra_funding 0 tmp_as_animals_bred [empty string] tmp_as_app_submitted [empty string] tmp_as_no_app_jit [empty string] tmp_as_no_app_not_submitted [empty string] tmp_as_protocol [empty string] tmp_as_species [empty string] tmp_as_surgery [empty string] tmp_as_tissue_collected [empty string] tmp_as_tumors_induced [empty string] tmp_award_admin_dept UTK-Electrical Engr tmp_award_admin_dept_no U013425040 tmp_award_type A1 Agency Fund - Sponsored tmp_award_type_2 [empty string] tmp_calendar_months [empty string] tmp_cfda_no [empty string] tmp_cfr_officer [empty string] tmp_chess_code_values 5 tmp_cip A99 tmp_classified_materials 0 tmp_community_service 1 tmp_community_service_international [empty string] tmp_community_service_nc 1 tmp_community_service_outside_nc 1 tmp_cost_share_account [empty string] tmp_cost_share_amount 0.00 tmp_cost_sharing 0 tmp_cs_mandatory [empty string] tmp_cs_mandatory_amount [empty string] tmp_cs_mandatory_fa [empty string] tmp_cs_mandatory_inkind [empty string] tmp_cs_mandatory_matching [empty string] tmp_cs_mandatory_other [empty string] tmp_cs_mandatory_salary_cap [empty string] tmp_cs_voluntary [empty string] tmp_cs_voluntary_amount [empty string] tmp_cs_voluntary_fa [empty string] tmp_cs_voluntary_inkind [empty string] tmp_cs_voluntary_matching [empty string] tmp_cs_voluntary_other [empty string] tmp_cs_voluntary_salary_cap [empty string] tmp_deadline_type [empty string] tmp_dept [empty string] tmp_dept_no [empty string] tmp_disclosed 0 tmp_disclosed_title [empty string] tmp_dod_form_2345 0 tmp_econ_development 1 tmp_econ_development_international [empty string] tmp_econ_development_nc 1 tmp_econ_development_outside_nc 1 tmp_economic_transfer NULL tmp_education_adult 1 tmp_education_adult_international [empty string] tmp_education_adult_nc 1 tmp_education_adult_outside_nc 1 tmp_education_child 1 tmp_education_child_international [empty string] tmp_education_child_nc 1 tmp_education_child_outside_nc 1 tmp_electronic_submission 1 tmp_electronic_submission_type Fastlane tmp_electronic_submission_type_desc [empty string] tmp_email [empty string] tmp_entity_gift 0 tmp_environment NULL tmp_equipment_not_available [empty string] tmp_fa_dist 0 tmp_fname [empty string] tmp_foreign_national 1 tmp_foreign_national_countries China tmp_foreign_travel 0 tmp_foreign_travel_countries [empty string] tmp_funding_sponsor_app_number [empty string] tmp_general_citizen 1 tmp_general_citizen_international [empty string] tmp_general_citizen_nc 1 tmp_general_citizen_outside_nc 1 tmp_global_readiness NULL tmp_gra_head_count 0 tmp_health NULL tmp_higher_education NULL tmp_hs_app_submitted [empty string] tmp_hs_direct_contact [empty string] tmp_hs_existing_data [empty string] tmp_hs_healthy_volunteers [empty string] tmp_hs_investigational [empty string] tmp_hs_minors [empty string] tmp_hs_multi_center [empty string] tmp_hs_no_app_jit [empty string] tmp_hs_no_app_not_submitted [empty string] tmp_hs_none NULL tmp_hs_patients [empty string] tmp_hs_pregnant [empty string] tmp_hs_prisoners [empty string] tmp_hs_protocol [empty string] tmp_hs_surveys [empty string] tmp_human_subjects 0 tmp_include_rad 1 tmp_initial_begin_date 2011-08-01 00:00:00.0 tmp_initial_direct 51629.00 tmp_initial_end_date 2012-07-31 00:00:00.0 tmp_initial_fa_amount 19829.81 tmp_initial_fa_amount2 0.00 tmp_initial_fa_base 40469.00 tmp_initial_fa_base2 0.00 tmp_initial_fa_rate 49.00 tmp_initial_fa_rate2 49.00 tmp_initial_total_funds 71458.81 tmp_involve_biological [empty string] tmp_involve_chemical [empty string] tmp_involve_neurotoxins [empty string] tmp_involve_radioactive [empty string] tmp_involve_sponsor_materials NULL tmp_items_to_ship [empty string] tmp_licensed_material [empty string] tmp_lname [empty string] tmp_mail_address [empty string] tmp_mail_admin [empty string] tmp_mail_copies [empty string] tmp_military_tech 0 tmp_nc_county_county_description [empty string] tmp_nc_county_location Knox tmp_nc_county_percent 100 tmp_nda [empty string] tmp_ofac_funds 0 tmp_on_campus_location KNOX-Philander P. Claxton Education Building-50113700 tmp_on_campus_percent 100 tmp_on_campus_room_no 222 tmp_other NULL tmp_owner_pid 00280818 tmp_parent_proposal_id 0 tmp_patent_potential [empty string] tmp_patents_filed 1 tmp_patents_issued [empty string] tmp_percent_effort [empty string] tmp_percent_effort_direct 0 tmp_percent_effort_share 0 tmp_phone [empty string] tmp_pid [empty string] tmp_previous_acct_number [empty string] tmp_primary NULL tmp_prime_sponsor NSF - National Science Foundation tmp_prime_sponsor_code [empty string] tmp_program_name Smart Health and Wellbeing (SHW) tmp_project_end_date 2014-07-31 00:00:00.0 tmp_project_name HIPS tmp_project_start_date 2011-08-01 00:00:00.0 tmp_proposal_guideline_url http://www.nsf.gov/funding/pgm_summ.jsp?pims_id=503556&org=CNS&from=home tmp_proposal_type New tmp_public_education NULL tmp_relationship_entity 0 tmp_relationship_executive 0 tmp_relationship_sponsor 0 tmp_relationship_subcontractor 0 tmp_request_support [empty string] tmp_research_results_countries [empty string] tmp_research_results_foreign 0 tmp_role [empty string] tmp_roles [empty string] tmp_sbir 0 tmp_security_clearance_needed 0 tmp_shipping_receiving_countries [empty string] tmp_shipping_receiving_foreign 0 tmp_snap [empty string] tmp_software 0 tmp_software_desc [empty string] tmp_sponsor NSF - National Science Foundation tmp_sponsor_code [empty string] tmp_sponsor_gift 0 tmp_sponsor_need_paper 0 tmp_sponsor_need_paper_type [empty string] tmp_sttr 0 tmp_sttr_org_relationship [empty string] tmp_sttr_pi [empty string] tmp_sttr_work_at_unc [empty string] tmp_subcontractor_name [empty string] tmp_submission_deadline 2010-12-17 00:00:00.0 tmp_submission_deadline_time 5:00pm tmp_submission_deadline_timezone Eastern tmp_submission_deadline_type Receipt tmp_summer 0 tmp_title SHW:Small: HIPS: A Security Architecture for Health Information Privacy and Sharing in Electronic Health Record (EHR) Systems tmp_total_begin_date 2011-08-01 00:00:00.0 tmp_total_direct 158162.00 tmp_total_end_date 2014-07-31 00:00:00.0 tmp_total_fa_amount 59398.78 tmp_total_fa_amount2 0.00 tmp_total_fa_base 121222.00 tmp_total_fa_base2 0.00 tmp_total_fa_rate 49.00 tmp_total_fa_rate2 49.00 tmp_total_total_funds 217560.78 tmp_transfer_agreement 0 tmp_within_unc 1 tmp_work_reduction 0 tmp_work_reduction_funded 0 urltoken CFID=79162&CFTOKEN=29935887 usenewprivs true userid 162 username JYSUN@tennessee.edu userrecid 162 wsauth error e: struct Browser Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_5; en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.215 Safari/534.10 DateTime {ts '2010-12-05 20:45:17'} Diagnostics Java heap space null <br>The error occurred on line -1. GeneratedContent <br /><br />Please wait while document is uploaded... <!-- if file not found --> <!-- check DOCTYPE info --> <!-- if mac, check filename --> HTTPReferer https://utk.tera.tennessee.edu/ramses/de_attachments.cfm?NoCache=1291599880802 Mailto maceo@email.unc.edu,terasupport@mail.tennessee.edu Message Java heap space QueryString [empty string] RemoteAddress 69.245.5.231 RootCause struct Message Java heap space StackTrace java.lang.OutOfMemoryError: Java heap space TagContext array [empty] Type java.lang.OutOfMemoryError StackTrace java.lang.OutOfMemoryError: Java heap space TagContext array [empty] Template /ramses/proc/validate_file_upload2.cfm Type coldfusion.runtime.CfErrorWrapper Request Vars: struct Form Vars: struct
Attachments
This is the file upload page code (37.12 KB, application/octet-stream)
2010-12-08 04:14 PST, Michael McGuire 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-12-07 10:47:57 PST
StackTrace java.lang.OutOfMemoryError: Java heap space Please provide steps to reproduce this problem. What exactly should one do to see it, step by step?
Michael McGuire
Comment 2 2010-12-08 04:14:40 PST
Created attachment 75886 [details] This is the file upload page code
supplyservice
Comment 3 2017-04-23 22:44:33 PDT Comment hidden (spam)
Note You need to log in before you can comment on or make changes to this bug.