Bug 50539

Summary: [Qt] Report zero width for zero size fonts
Product: WebKit Reporter: Robert Hogan <robert>
Component: WebKit QtAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Robert Hogan 2010-12-05 09:45:15 PST
.
Comment 1 Robert Hogan 2010-12-05 09:55:25 PST
Created attachment 75632 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-12-05 14:03:34 PST
Comment on attachment 75632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75632&action=review

pls fix before landing

> WebCore/platform/graphics/qt/FontQt.cpp:266
> +        return 0.0f;

this should be 0 according to the style guide

> WebCore/platform/graphics/qt/FontQt.cpp:291
> +        return 0.0f;

here as well
Comment 3 Csaba Osztrogon√°c 2010-12-06 02:26:28 PST
Comment on attachment 75632 [details]
Patch

Fixed patch landed in http://trac.webkit.org/changeset/73352
Comment 4 Robert Hogan 2010-12-06 11:26:36 PST
Andreas/Kenneth,

Is there a bit of a disconnect between Font::drawTextCommon and the actual size of the font (according to webkit)? It uses FontMetrics which may not be appropriate in the case of zero-sized fonts. I suspect QtWebKit is rendering the font full-sized rather than 'no-sized' because of this. What do you think?