Bug 50477 – REGRESSION(r71934): input event fires twice when editing text inside a text input.

• Component: New Bugs
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

REGRESSION(r71934): input event fires twice when editing text inside a text input.

[Dimitri Glazkov (Google)]

Created attachment 75532 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 75532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75532&action=review

> LayoutTests/fast/forms/text-input-event.html:44
>  \ No newline at end of file

Ha. I forgot the newline again. I'll add upon landing.

[Dimitri Glazkov (Google)]

Created attachment 75533 [details]
Now with a better ChangeLog

[Darin Adler]

Comment on attachment 75533 [details]
Now with a better ChangeLog

I’m not sure I completely understand our approach; seems more like we would not want the event to exit the shadow.

This changes the timing of the input event too. It now happens earlier. Does that have any detectable side effects?

[Dimitri Glazkov (Google)]

(In reply to comment #4)
> (From update of attachment 75533 [details])
> I’m not sure I completely understand our approach; seems more like we would not want the event to exit the shadow.
> 
> This changes the timing of the input event too. It now happens earlier. Does that have any detectable side effects?

It actually happens later now. InputElement::setValueFromRenderer is invoked from HTMLFormControlElementWithState::defaultEventHandler.

However, both of these events are a response to the same specific webkitEditableContentChangedEvent, so there's really no perceptible difference in when they occur.

[Dimitri Glazkov (Google)]

Committed r73319: <http://trac.webkit.org/changeset/73319>

[Dimitri Glazkov (Google)]

*** Bug 50476 has been marked as a duplicate of this bug. ***