|Summary:||Web Inspector: Heap profile isn't shown if profiles are selected in a particular order|
|Product:||WebKit||Reporter:||Mikhail Naganov <mnaganov>|
|Component:||Web Inspector (Deprecated)||Assignee:||Mikhail Naganov <mnaganov>|
|Severity:||Normal||CC:||apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys|
|Version:||528+ (Nightly build)|
Description Mikhail Naganov 2010-12-02 17:15:35 PST
http://code.google.com/p/chromium/issues/detail?id=65201 What steps will reproduce the problem? 1. Open any page (say, google.com) 2. Open DevTools, go to "Profiles" page. 3. Take 3 heap snapshots; "Snapshot 1" will be selected automatically 4. Select "Snapshot 3" -- its contents will never be shown (although, clicking on "Snapshot 2" shows the contents). If in step 4., instead of jumping to "Snapshot 3", one will select "Snapshot 2", and then "Snapshot 3", all snapshots will be shown.
Comment 2 Eric Seidel (no email) 2010-12-02 17:26:17 PST
Comment on attachment 75442 [details] proposed fix Seems you'll need someone who knows the inspector to look. You can use webkit-patch suggest-reviewers to find appropriate reviewers, or pass --suggest-reviewers to webkit-patch upload to have them automatically CC'd when you post a patch.
Comment 3 Eric Seidel (no email) 2010-12-02 17:26:46 PST
Nevermind. With 10 people already CC'd you should be fine. :) I clearly started at the wrong end of the review queue.
Comment 4 Mikhail Naganov 2010-12-02 17:38:41 PST
Yep, there is a special template for Inspector bugs that includes all relevant people into CC list.
Comment 5 Pavel Feldman 2010-12-02 18:08:05 PST
Comment on attachment 75442 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=75442&action=review > WebCore/ChangeLog:5 > + Fix heap snapshots loading. Loading is now conducted by the Web Inspector: > WebCore/inspector/front-end/ProfilesPanel.js:419 > + if (profile._loaded) blank line above.
Comment 6 Mikhail Naganov 2010-12-02 18:13:12 PST
Comment on attachment 75442 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=75442&action=review >> WebCore/ChangeLog:5 >> + Fix heap snapshots loading. Loading is now conducted by the > > Web Inspector: Done >> WebCore/inspector/front-end/ProfilesPanel.js:419 >> + if (profile._loaded) > > blank line above. Fixed here and below.
Comment 7 Mikhail Naganov 2010-12-02 19:43:44 PST
Manually committed: http://trac.webkit.org/changeset/73229 2010-12-02 Mikhail Naganov <firstname.lastname@example.org> Reviewed by Pavel Feldman. Web Inspector: Fix heap snapshots loading. Loading is now conducted by the Profiles panel which prevents accidental simultaneous attempts to load the same profile several times in parallel. https://bugs.webkit.org/show_bug.cgi?id=50427 * inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):