Summary: | Web Inspector: Heap profile isn't shown if profiles are selected in a particular order | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Mikhail Naganov <mnaganov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Mikhail Naganov
2010-12-02 17:15:35 PST
Created attachment 75442 [details]
proposed fix
Comment on attachment 75442 [details]
proposed fix
Seems you'll need someone who knows the inspector to look. You can use webkit-patch suggest-reviewers to find appropriate reviewers, or pass --suggest-reviewers to webkit-patch upload to have them automatically CC'd when you post a patch.
Nevermind. With 10 people already CC'd you should be fine. :) I clearly started at the wrong end of the review queue. Yep, there is a special template for Inspector bugs that includes all relevant people into CC list. Comment on attachment 75442 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=75442&action=review > WebCore/ChangeLog:5 > + Fix heap snapshots loading. Loading is now conducted by the Web Inspector: > WebCore/inspector/front-end/ProfilesPanel.js:419 > + if (profile._loaded) blank line above. Comment on attachment 75442 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=75442&action=review >> WebCore/ChangeLog:5 >> + Fix heap snapshots loading. Loading is now conducted by the > > Web Inspector: Done >> WebCore/inspector/front-end/ProfilesPanel.js:419 >> + if (profile._loaded) > > blank line above. Fixed here and below. Manually committed: http://trac.webkit.org/changeset/73229 2010-12-02 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: Fix heap snapshots loading. Loading is now conducted by the Profiles panel which prevents accidental simultaneous attempts to load the same profile several times in parallel. https://bugs.webkit.org/show_bug.cgi?id=50427 * inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot): |