Summary: | WebCore should handled MIME types to allow SVG support | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||
Component: | WebKit Misc. | Assignee: | Eric Seidel (no email) <eric> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | ||||||||||||
Priority: | P4 | ||||||||||||
Version: | 420+ | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.4 | ||||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2005-09-18 03:47:12 PDT
Created attachment 3931 [details]
The webkit portion of the patch.
Created attachment 3932 [details]
The WebCore portion of the patch.
1) I suggest using NSArray instead of NSSet for the lists of supported MIME types; the associative properties of a set are not required, and so an array is likely to be more efficient. 2) I would support putting the list of supported MIME types in WebCore if it were shared with or used by WebCore in any way - as it is, it just seems to be adding more levels of indirection. Created attachment 3961 [details]
Updated WebKit patch
Created attachment 3962 [details]
Updated WebCore patch
Comment on attachment 3962 [details]
Updated WebCore patch
r=me
|