Bug 50359

Summary: [chromium] force NRWT to use DRT
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, ojan, victorw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ojan: review+

Tony Chang
Reported 2010-12-01 16:44:16 PST
[chromium] force NRWT to use DRT
Attachments
Patch (1.42 KB, patch)
2010-12-01 16:44 PST, Tony Chang 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-12-01 16:44:41 PST
Created attachment 75333 [details] Patch
Tony Chang
Comment 2 2010-12-01 16:45:51 PST
This is intentionally small so when the canaries break, I can roll back. If it sticks, I'll make a follow up patch to remove the flag (and to remove the flag from the bots).
Dirk Pranke
Comment 3 2010-12-01 16:47:08 PST
Heh. LGTM!
Tony Chang
Comment 4 2010-12-02 10:59:25 PST
Just an fyi for victorw, the current gardener.
Tony Chang
Comment 5 2010-12-02 11:00:23 PST
Committed r73164: <http://trac.webkit.org/changeset/73164>
Tony Chang
Comment 6 2010-12-02 15:20:44 PST
Reverted r73164 for reason: broke debugger tests on win Committed r73207: <http://trac.webkit.org/changeset/73207>
Tony Chang
Comment 7 2010-12-07 13:06:05 PST
Committed r73456: <http://trac.webkit.org/changeset/73456>
Dirk Pranke
Comment 8 2010-12-07 20:20:01 PST
Okay, I should have caught this before, but realizing this now ... changing the default this way doesn't give us a way to run w/ TestShell anymore. We need to add a --no-use-drt flag (or a --use-test-shell or something). It's not hard to hack the RWT code to work around this, obviously, and we don't really want to encourage people to use this code, but as long as TestShell is being supported, I'd prefer we have a way to run this without local mods. Thoughts? Also, any thought as to when we might actually stop supporting TestShell and remove the code from the Tree?
Ojan Vafai
Comment 9 2010-12-08 08:39:58 PST
This was the most expedient way we could think of making this change. The plan, if this sticks for the next day or two, is to fully remove all TestShell support.
Tony Chang
Comment 10 2010-12-08 09:57:20 PST
I'm going to write a patch today for --use-test-shell (jamesr's recommendation for testing for DRT specific failures). As mentioned in comment #2, this patch was intentionally small.
Dirk Pranke
Comment 11 2010-12-08 11:00:53 PST
(In reply to comment #10) > I'm going to write a patch today for --use-test-shell (jamesr's recommendation for testing for DRT specific failures). > > As mentioned in comment #2, this patch was intentionally small. Sure, I think keeping the patch small was a good thing to. Just a bit too small ;)
Note You need to log in before you can comment on or make changes to this bug.